mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-29 19:50:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

directdrawsink: avoid rendering to invalid area

Browse source 
Based on patch by Havard Graff <havard.graff@tandberg.com>

Fixes #594280.
This commit is contained in:
Mark Nauwelaerts 2011-02-07 22:47:34 +01:00
parent 15366355a4
commit edb15598ed
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sys/directdraw/gstdirectdrawsink.c
View file

@ -904,6 +904,19 @@ gst_directdraw_sink_show_frame (GstBaseSink * bsink, GstBuffer * buf)
GetClientRect (ddrawsink->video_window, &destsurf_rect); GetClientRect (ddrawsink->video_window, &destsurf_rect);
OffsetRect (&destsurf_rect, dest_surf_point.x, dest_surf_point.y); OffsetRect (&destsurf_rect, dest_surf_point.x, dest_surf_point.y);
/* Check to see if we have an area to draw to.
* When the window is minimized, it will trigger the
* "IDirectDrawSurface7_Blt (object's offscreen surface)" warning,
* with a msg that the rectangle is invalid */
if (destsurf_rect.right <= destsurf_rect.left ||
destsurf_rect.bottom <= destsurf_rect.top) {
GST_OBJECT_UNLOCK (ddrawsink);
GST_DEBUG_OBJECT (ddrawsink, "invalid rendering window rectangle "
"(%ld, %ld), (%ld, %ld)", destsurf_rect.left, destsurf_rect.top,
destsurf_rect.right, destsurf_rect.bottom);
goto beach;
}
if (ddrawsink->keep_aspect_ratio) { if (ddrawsink->keep_aspect_ratio) {
/* center image to dest image keeping aspect ratio */ /* center image to dest image keeping aspect ratio */
src_rect.top = 0; src_rect.top = 0;
@ -1004,6 +1017,7 @@ gst_directdraw_sink_show_frame (GstBaseSink * bsink, GstBuffer * buf)
"returned %s", DDErrorString (hRes)); "returned %s", DDErrorString (hRes));
} }
beach:
return GST_FLOW_OK; return GST_FLOW_OK;
} }