mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-27 10:40:34 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin3: Don't duplicate stream selections

Browse source 
Make sure that the requested stream selection isn't identical to the current
one. If that's the case, just carry on as usual.

This avoids multiple `streams-selected` posting ... when the selection didn't
change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2185>
This commit is contained in:
Edward Hervey 2022-04-14 15:21:48 +02:00 committed by GStreamer Marge Bot
parent ea80952998
commit ed5db9bce7
1 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c
View file

@ -1177,6 +1177,23 @@ stream_in_list (GList * list, const gchar * sid)
return NULL;
}
static gboolean
stream_list_equal (GList * lista, GList * listb)
{
GList *tmp;
if (g_list_length (lista) != g_list_length (listb))
return FALSE;
for (tmp = lista; tmp; tmp = tmp->next) {
gchar *osid = tmp->data;
if (!stream_in_list (listb, osid))
return FALSE;
}
return TRUE;
}
static void
update_requested_selection (GstDecodebin3 * dbin)
{
@ -1253,8 +1270,15 @@ update_requested_selection (GstDecodebin3 * dbin)
}
beach:
/* Finally set the requested selection */
if (stream_list_equal (tmp, dbin->requested_selection)) {
/* If the selection is equal, there is nothign to do */
GST_DEBUG_OBJECT (dbin, "Dropping duplicate selection");
g_list_free (tmp);
tmp = NULL;
}
if (tmp) {
/* Finally set the requested selection */
if (dbin->requested_selection) {
GST_FIXME_OBJECT (dbin,
"Replacing non-NULL requested_selection, what should we do ??");