mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpbin: Cleanup dead code

Browse source 
The rtpjitterbuffer is now part of the session elements, we no longer need
to do the ref_sink dance when signalling it. It is already owned by the bin
when signalled. Also, the code that handles generic session elements already
handle the ref_sink() calls since:

03dc22951b

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/735>
This commit is contained in:
Nicolas Dufresne 2020-09-23 13:26:51 -04:00
parent ea61714c70
commit ecc110ca8b
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/rtpmanager/gstrtpbin.c
View file

@ -1790,19 +1790,12 @@ create_stream (GstRtpBinSession * session, guint32 ssrc)
g_object_set (buffer, "max-ts-offset-adjustment", g_object_set (buffer, "max-ts-offset-adjustment",
rtpbin->max_ts_offset_adjustment, NULL); rtpbin->max_ts_offset_adjustment, NULL);
/* need to sink the jitterbufer or otherwise signal handlers from bindings will
* take ownership of it and we don't own it anymore */
gst_object_ref_sink (buffer);
g_signal_emit (rtpbin, gst_rtp_bin_signals[SIGNAL_NEW_JITTERBUFFER], 0, g_signal_emit (rtpbin, gst_rtp_bin_signals[SIGNAL_NEW_JITTERBUFFER], 0,
buffer, session->id, ssrc); buffer, session->id, ssrc);
if (!rtpbin->ignore_pt) if (!rtpbin->ignore_pt)
gst_bin_add (GST_BIN_CAST (rtpbin), demux); gst_bin_add (GST_BIN_CAST (rtpbin), demux);
/* unref the jitterbuffer again, the bin has a reference now and
* we don't need it anymore */
gst_object_unref (buffer);
/* link stuff */ /* link stuff */
if (demux) if (demux)
gst_element_link_pads_full (buffer, "src", demux, "sink", gst_element_link_pads_full (buffer, "src", demux, "sink",