mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-03 13:16:04 +00:00
Code Issues 1 Projects Releases Wiki Activity

oggdemux: Fix chain leak in push mode

Browse source 
In some corner cases we end up with the building chain not being
properly tracked (and therefore not properly freed).

Add a FIXME so it can later be fixed, but for now just fix the leak
This commit is contained in:
Edward Hervey 2017-11-01 11:18:12 +01:00 committed by Edward Hervey
parent 8e867aefe0
commit eb8bf0f162
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ext/ogg/gstoggdemux.c
View file

@ -4988,11 +4988,23 @@ gst_ogg_demux_clear_chains (GstOggDemux * ogg)
for (i = 0; i < ogg->chains->len; i++) {
GstOggChain *chain = g_array_index (ogg->chains, GstOggChain *, i);
if (chain == ogg->current_chain)
ogg->current_chain = NULL;
if (chain == ogg->building_chain)
ogg->building_chain = NULL;
gst_ogg_chain_free (chain);
}
ogg->chains = g_array_set_size (ogg->chains, 0);
ogg->current_chain = NULL;
ogg->building_chain = NULL;
if (ogg->current_chain != NULL) {
GST_FIXME_OBJECT (ogg, "current chain was tracked in existing chains !");
gst_ogg_chain_free (ogg->current_chain);
ogg->current_chain = NULL;
}
if (ogg->building_chain != NULL) {
GST_FIXME_OBJECT (ogg, "building chain was tracked in existing chains !");
gst_ogg_chain_free (ogg->building_chain);
ogg->building_chain = NULL;
}
GST_CHAIN_UNLOCK (ogg);
}