libs: surface: egl: error message if no extension

Instead of silently fail to export the image if there is not available
the EGL_MESA_drm_image, log an error message. Also a code refactoring
was done.

https://bugzilla.gnome.org/show_bug.cgi?id=773453
This commit is contained in:
Víctor Manuel Jáquez Leal 2017-10-04 13:51:23 +02:00
parent 72362e1063
commit ea503ed085

View file

@ -55,22 +55,30 @@ do_create_surface_with_egl_image_unlocked (GstVaapiDisplayEGL * display,
memset (offset, 0, sizeof (offset));
memset (stride, 0, sizeof (stride));
if (vtable->has_EGL_MESA_drm_image) {
/* EGL_MESA_drm_image extension */
if (!vtable->eglExportDRMImageMESA (ctx->display->base.handle.p, image,
&name, NULL, &stride[0]))
goto error_export_image_gem_buf;
if (!vtable->has_EGL_MESA_drm_image)
goto error_mission_extension;
size = height * stride[0];
return gst_vaapi_surface_new_with_gem_buf_handle (base_display, name, size,
format, width, height, offset, stride);
}
return NULL;
/* EGL_MESA_drm_image extension */
if (!vtable->eglExportDRMImageMESA (ctx->display->base.handle.p, image,
&name, NULL, &stride[0]))
goto error_export_image_gem_buf;
size = height * stride[0];
return gst_vaapi_surface_new_with_gem_buf_handle (base_display, name, size,
format, width, height, offset, stride);
/* ERRORS */
error_export_image_gem_buf:
GST_ERROR ("failed to export EGL image to GEM buffer");
return NULL;
{
GST_ERROR ("failed to export EGL image to GEM buffer");
return NULL;
}
error_mission_extension:
{
GST_ERROR ("missing EGL_MESA_drm_image extension");
return NULL;
}
}
static void