mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

encodebin: guard against gst_pad_get_peer returning NULL

Browse source 
If it does, the pad may be leaked if it's a request pad, though.

Coverity 1139799
This commit is contained in:
Vincent Penquerc'h 2014-04-10 13:28:30 +01:00
parent 1afa3040b8
commit ea176f3865
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gst/encoding/gstencodebin.c
View file

@ -1890,13 +1890,15 @@ stream_group_free (GstEncodeBin * ebin, StreamGroup * sgroup)
tmppad = gst_element_get_static_pad (sgroup->outqueue, "src");
pad = gst_pad_get_peer (tmppad);
/* Remove muxer request sink pad */
gst_pad_unlink (tmppad, pad);
if (GST_PAD_TEMPLATE_PRESENCE (GST_PAD_PAD_TEMPLATE (pad)) ==
GST_PAD_REQUEST)
gst_element_release_request_pad (ebin->muxer, pad);
if (pad) {
/* Remove muxer request sink pad */
gst_pad_unlink (tmppad, pad);
if (GST_PAD_TEMPLATE_PRESENCE (GST_PAD_PAD_TEMPLATE (pad)) ==
GST_PAD_REQUEST)
gst_element_release_request_pad (ebin->muxer, pad);
gst_object_unref (pad);
}
gst_object_unref (tmppad);
gst_object_unref (pad);
}
if (sgroup->outqueue)
gst_element_set_state (sgroup->outqueue, GST_STATE_NULL);