mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-30 04:00:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Hold lock while accessing the codec preferences

Browse source 
They could be changed at runtime by the application, so take the lock
when modifying them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2183>
This commit is contained in:
Olivier Crête 2021-04-30 14:55:41 -04:00
parent 6a3a62abae
commit e9f14ed117
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst-libs/gst/webrtc/rtptransceiver.c
View file

@ -81,10 +81,14 @@ gst_webrtc_rtp_transceiver_set_property (GObject * object, guint prop_id,
webrtc->mline = g_value_get_uint (value); webrtc->mline = g_value_get_uint (value);
break; break;
case PROP_DIRECTION: case PROP_DIRECTION:
GST_OBJECT_LOCK (webrtc);
webrtc->direction = g_value_get_enum (value); webrtc->direction = g_value_get_enum (value);
GST_OBJECT_UNLOCK (webrtc);
break; break;
case PROP_CODEC_PREFERENCES: case PROP_CODEC_PREFERENCES:
GST_OBJECT_LOCK (webrtc);
gst_caps_replace (&webrtc->codec_preferences, g_value_get_boxed (value)); gst_caps_replace (&webrtc->codec_preferences, g_value_get_boxed (value));
GST_OBJECT_UNLOCK (webrtc);
break; break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
@ -112,7 +116,9 @@ gst_webrtc_rtp_transceiver_get_property (GObject * object, guint prop_id,
g_value_set_uint (value, webrtc->mline); g_value_set_uint (value, webrtc->mline);
break; break;
case PROP_DIRECTION: case PROP_DIRECTION:
GST_OBJECT_LOCK (webrtc);
g_value_set_enum (value, webrtc->direction); g_value_set_enum (value, webrtc->direction);
GST_OBJECT_UNLOCK (webrtc);
break; break;
case PROP_CURRENT_DIRECTION: case PROP_CURRENT_DIRECTION:
g_value_set_enum (value, webrtc->current_direction); g_value_set_enum (value, webrtc->current_direction);
@ -121,7 +127,9 @@ gst_webrtc_rtp_transceiver_get_property (GObject * object, guint prop_id,
g_value_set_enum (value, webrtc->kind); g_value_set_enum (value, webrtc->kind);
break; break;
case PROP_CODEC_PREFERENCES: case PROP_CODEC_PREFERENCES:
GST_OBJECT_LOCK (webrtc);
gst_value_set_caps (value, webrtc->codec_preferences); gst_value_set_caps (value, webrtc->codec_preferences);
GST_OBJECT_UNLOCK (webrtc);
break; break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);