mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-24 08:08:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridecodebin: post proper error message if decodebin2/typefind elements are missing

Browse source 
Post better error messages in case typefind/decodebin2 are missing or
could not be loaded for some reason (e.g. because they inadvertently
got blacklisted).

https://bugzilla.gnome.org/show_bug.cgi?id=644892
This commit is contained in:
Tim-Philipp Müller 2011-03-16 10:19:42 +00:00
parent 185a8ddcaa
commit e8f5b3a579
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
gst/playback/gsturidecodebin.c
View file

@ -1539,6 +1539,11 @@ make_decoder (GstURIDecodeBin * decoder)
if (!decodebin) if (!decodebin)
goto no_decodebin; goto no_decodebin;
/* sanity check */
if (decodebin->numsinkpads == 0)
goto no_typefind;
/* connect signals to proxy */ /* connect signals to proxy */
g_signal_connect (decodebin, "unknown-type", g_signal_connect (decodebin, "unknown-type",
G_CALLBACK (proxy_unknown_type_signal), decoder); G_CALLBACK (proxy_unknown_type_signal), decoder);
@ -1609,6 +1614,15 @@ make_decoder (GstURIDecodeBin * decoder)
no_decodebin: no_decodebin:
{ {
post_missing_plugin_error (GST_ELEMENT_CAST (decoder), "decodebin2"); post_missing_plugin_error (GST_ELEMENT_CAST (decoder), "decodebin2");
GST_ELEMENT_ERROR (decoder, CORE, MISSING_PLUGIN, (NULL),
("No decodebin2 element, check your installation"));
return NULL;
}
no_typefind:
{
gst_object_unref (decodebin);
GST_ELEMENT_ERROR (decoder, CORE, MISSING_PLUGIN, (NULL),
("No typefind element, decodebin2 is unusable, check your installation"));
return NULL; return NULL;
} }
} }
@ -1762,6 +1776,8 @@ setup_streaming (GstURIDecodeBin * decoder)
no_typefind: no_typefind:
{ {
post_missing_plugin_error (GST_ELEMENT_CAST (decoder), "typefind"); post_missing_plugin_error (GST_ELEMENT_CAST (decoder), "typefind");
GST_ELEMENT_ERROR (decoder, CORE, MISSING_PLUGIN, (NULL),
("No typefind element, check your installation"));
return FALSE; return FALSE;
} }
could_not_link: could_not_link: