mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:36:20 +00:00
Code Issues 1 Projects Releases Wiki Activity

basesrc: move the quick return up

Browse source 
Don't assign local vars if we skip anyway. Add logging for failure conditio
This commit is contained in:
Stefan Sauer 2014-09-25 20:23:31 +02:00
parent acb67fee6e
commit e8c5627802
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
libs/gst/base/gstbasesrc.c
View file

@ -2310,20 +2310,18 @@ gst_base_src_update_length (GstBaseSrc * src, guint64 offset, guint * length,
{ {
guint64 size, maxsize; guint64 size, maxsize;
GstBaseSrcClass *bclass; GstBaseSrcClass *bclass;
GstFormat format;
gint64 stop; gint64 stop;
/* only operate if we are working with bytes */
if (src->segment.format != GST_FORMAT_BYTES)
return TRUE;
bclass = GST_BASE_SRC_GET_CLASS (src); bclass = GST_BASE_SRC_GET_CLASS (src);
format = src->segment.format;
stop = src->segment.stop; stop = src->segment.stop;
/* get total file size */ /* get total file size */
size = src->segment.duration; size = src->segment.duration;
/* only operate if we are working with bytes */
if (format != GST_FORMAT_BYTES)
return TRUE;
/* when not doing automatic EOS, just use the stop position. We don't use /* when not doing automatic EOS, just use the stop position. We don't use
* the size to check for EOS */ * the size to check for EOS */
if (!g_atomic_int_get (&src->priv->automatic_eos)) if (!g_atomic_int_get (&src->priv->automatic_eos))
@ -2379,6 +2377,7 @@ gst_base_src_update_length (GstBaseSrc * src, guint64 offset, guint * length,
/* ERRORS */ /* ERRORS */
unexpected_length: unexpected_length:
{ {
GST_WARNING_OBJECT (src, "processing at or past EOS");
return FALSE; return FALSE;
} }
} }