mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-29 11:40:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

gluploadelement: Avoid race condition of base class' context.

Browse source 
The base class' context may change, we should use the common API
with lock to access it, rather than the just directly access the
struct field.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/916>
This commit is contained in:
He Junyan 2020-11-04 17:02:13 +08:00 committed by GStreamer Merge Bot
parent 941629291b
commit e8bb524278
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ext/gl/gstgluploadelement.c
View file

@ -167,7 +167,7 @@ _gst_gl_upload_element_transform_caps (GstBaseTransform * bt,
if (base_filter->display && !gst_gl_base_filter_find_gl_context (base_filter))
return NULL;
context = GST_GL_BASE_FILTER (bt)->context;
context = gst_gl_base_filter_get_gl_context (base_filter);
GST_OBJECT_LOCK (upload);
if (upload->upload == NULL) {
@ -191,7 +191,10 @@ _gst_gl_upload_element_transform_caps (GstBaseTransform * bt,
ret_caps =
gst_gl_upload_transform_caps (ul, context, direction, caps, filter);
gst_object_unref (ul);
if (context)
gst_object_unref (context);
return ret_caps;
}