mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-06 16:19:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/gstpad.c: The default event function on a sinkpad should return TRUE when there are no internal links but should ...

Browse source 
Original commit message from CVS:
* gst/gstpad.c: (gst_pad_event_default_dispatch):
The default event function on a sinkpad should return TRUE when
there are no internal links but should collect the return values from
the internal links otherwise.
This commit is contained in:
Wim Taymans 2008-05-27 10:59:38 +00:00
parent 7a0d8307e8
commit e84afb820d
2 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
2008-05-27 Wim Taymans <wim.taymans@collabora.co.uk>
* gst/gstpad.c: (gst_pad_event_default_dispatch):
The default event function on a sinkpad should return TRUE when
there are no internal links but should collect the return values from
the internal links otherwise.
2008-05-27 Wim Taymans <wim.taymans@collabora.co.uk>
* plugins/elements/gsttypefindelement.c:

15
gst/gstpad.c
View file

@ -2972,10 +2972,19 @@ gst_pad_event_default_dispatch (GstPad * pad, GstEvent * event)
GST_INFO_OBJECT (pad, "Sending event %p (%s) to all internally linked pads",
event, GST_EVENT_TYPE_NAME (event));
result = (GST_PAD_DIRECTION (pad) == GST_PAD_SINK);
orig = pads = gst_pad_get_internal_links (pad);
if (!pads) {
/* If this is a sinkpad and we don't have pads to send the event to, we
* return TRUE. This is so that when using the default handler on a sink
* element, we don't fail to push it. */
result = (GST_PAD_DIRECTION (pad) == GST_PAD_SINK);
} else {
/* we have pads, the result will be TRUE if one of the pads handled the
* event in the code below. */
result = FALSE;
}
while (pads) {
GstPad *eventpad = GST_PAD_CAST (pads->data);
@ -2987,7 +2996,7 @@ gst_pad_event_default_dispatch (GstPad * pad, GstEvent * event)
GST_LOG_OBJECT (pad, "Reffing and sending event %p (%s) to %s:%s",
event, GST_EVENT_TYPE_NAME (event), GST_DEBUG_PAD_NAME (eventpad));
gst_event_ref (event);
gst_pad_push_event (eventpad, event);
result |= gst_pad_push_event (eventpad, event);
} else {
/* we only send the event on one pad, multi-sinkpad elements
* should implement a handler */