mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-03 04:52:28 +00:00
Code Issues 1 Projects Releases Wiki Activity

gl/wayland: Don't prefix wl_shell struct field

Browse source 
As part of commit 808e7127, we prefixed the `GstWlWindow`'s `shell`
field with wl_, to differentiate it from the other types of shells a
Wayland compositor might support. However, this is apparently a struct
that we expose to our users, so changing it means we have an API break.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/592
This commit is contained in:
Niels De Graef 2019-04-24 10:41:24 +02:00 committed by Sebastian Dröge
parent 5f19e83f14
commit e8450397c0
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst-libs/gst/gl/wayland/gstgldisplay_wayland.c
View file

@ -76,8 +76,7 @@ registry_handle_global (void *data, struct wl_registry *registry,
xdg_wm_base_add_listener (priv->xdg_wm_base, &xdg_wm_base_listener, xdg_wm_base_add_listener (priv->xdg_wm_base, &xdg_wm_base_listener,
display); display);
} else if (g_strcmp0 (interface, "wl_shell") == 0) { } else if (g_strcmp0 (interface, "wl_shell") == 0) {
display->wl_shell = display->shell = wl_registry_bind (registry, name, &wl_shell_interface, 1);
wl_registry_bind (registry, name, &wl_shell_interface, 1);
} }
} }
@ -119,7 +118,7 @@ gst_gl_display_wayland_finalize (GObject * object)
GstGLDisplayWaylandPrivate *priv = GstGLDisplayWaylandPrivate *priv =
gst_gl_display_wayland_get_instance_private (display_wayland); gst_gl_display_wayland_get_instance_private (display_wayland);
g_clear_pointer (&display_wayland->wl_shell, wl_shell_destroy); g_clear_pointer (&display_wayland->shell, wl_shell_destroy);
g_clear_pointer (&priv->xdg_wm_base, xdg_wm_base_destroy); g_clear_pointer (&priv->xdg_wm_base, xdg_wm_base_destroy);
/* Cause eglTerminate() to occur before wl_display_disconnect() /* Cause eglTerminate() to occur before wl_display_disconnect()

2
gst-libs/gst/gl/wayland/gstgldisplay_wayland.h
View file

@ -58,7 +58,7 @@ struct _GstGLDisplayWayland
struct wl_subcompositor *subcompositor; struct wl_subcompositor *subcompositor;
/* Basic shell, see private struct for others (e.g. XDG-shell) */ /* Basic shell, see private struct for others (e.g. XDG-shell) */
struct wl_shell *wl_shell; struct wl_shell *shell;
/* <private> */ /* <private> */
gboolean foreign_display; gboolean foreign_display;

2
gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c
View file

@ -342,7 +342,7 @@ create_wl_shell_surface (GstGLWindowWaylandEGL * window_egl)
GST_DEBUG ("Creating surfaces for wl-shell"); GST_DEBUG ("Creating surfaces for wl-shell");
wl_shell_surface = wl_shell_get_shell_surface (display->wl_shell, wl_shell_surface = wl_shell_get_shell_surface (display->shell,
window_egl->window.surface); window_egl->window.surface);
if (window_egl->window.queue) { if (window_egl->window.queue) {