filesrc: cleanup error path

This commit is contained in:
Wim Taymans 2011-12-06 13:47:29 +01:00
parent 1ac7160031
commit e7e948a5bf

View file

@ -518,7 +518,7 @@ no_filename:
{ {
GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND,
(_("No file name specified for reading.")), (NULL)); (_("No file name specified for reading.")), (NULL));
return FALSE; goto error_exit;
} }
open_failed: open_failed:
{ {
@ -533,29 +533,30 @@ open_failed:
GST_ERROR_SYSTEM); GST_ERROR_SYSTEM);
break; break;
} }
return FALSE; goto error_exit;
} }
no_stat: no_stat:
{ {
GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
(_("Could not get info on \"%s\"."), src->filename), (NULL)); (_("Could not get info on \"%s\"."), src->filename), (NULL));
close (src->fd); goto error_close;
return FALSE;
} }
was_directory: was_directory:
{ {
GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
(_("\"%s\" is a directory."), src->filename), (NULL)); (_("\"%s\" is a directory."), src->filename), (NULL));
close (src->fd); goto error_close;
return FALSE;
} }
was_socket: was_socket:
{ {
GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ,
(_("File \"%s\" is a socket."), src->filename), (NULL)); (_("File \"%s\" is a socket."), src->filename), (NULL));
close (src->fd); goto error_close;
return FALSE;
} }
error_close:
close (src->fd);
error_exit:
return FALSE;
} }
/* unmap and close the file */ /* unmap and close the file */