mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-03 06:39:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

dc1394src: Remove logically dead code

Browse source 
buffer would always be NULL in the error case. Simplify and just
return GST_FLOW_ERROR

CID #1417216
This commit is contained in:
Edward Hervey 2017-11-24 07:57:49 +01:00 committed by Edward Hervey
parent c91187c187
commit e7724354d9
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ext/dc1394/gstdc1394src.c
View file

@ -317,18 +317,17 @@ static GstFlowReturn
gst_dc1394_src_create (GstPushSrc * psrc, GstBuffer ** obuf)
{
GstDC1394Src *src;
GstBuffer *buffer;
GstBuffer *buffer = NULL;
dc1394video_frame_t *frame;
dc1394error_t ret;
src = GST_DC1394_SRC (psrc);
buffer = NULL;
ret = dc1394_capture_dequeue (src->camera, DC1394_CAPTURE_POLICY_WAIT,
&frame);
if (ret != DC1394_SUCCESS) {
GST_ELEMENT_ERROR (src, RESOURCE, READ, (NULL),
("Could not dequeue frame: %s.", dc1394_error_get_string (ret)));
goto error;
return GST_FLOW_ERROR;
}
/*
* TODO: We could create the buffer by wrapping the image bytes in the frame
@ -351,11 +350,6 @@ gst_dc1394_src_create (GstPushSrc * psrc, GstBuffer ** obuf)
}
*obuf = buffer;
return GST_FLOW_OK;
error:
if (buffer)
gst_buffer_unref (buffer);
return GST_FLOW_ERROR;
}