mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-05 15:08:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

isomp4: remove unused parameters in build_*_extension

Browse source 
AtomTRAK parameter is not used by build_mov_alac_extension(),
build_jp2h_extension(), or build_mov_alac_extension()  and can be
removed.
This commit is contained in:
Luis de Bethencourt 2015-12-10 17:41:46 +00:00
parent 3a38682cf0
commit e731fe4af5
3 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst/isomp4/atoms.c
View file

@ -3468,7 +3468,7 @@ atom_trak_set_audio_type (AtomTRAK * trak, AtomsContext * context,
} }
static AtomInfo * static AtomInfo *
build_pasp_extension (AtomTRAK * trak, gint par_width, gint par_height) build_pasp_extension (gint par_width, gint par_height)
{ {
AtomData *atom_data = atom_data_new (FOURCC_pasp); AtomData *atom_data = atom_data_new (FOURCC_pasp);
guint8 *data; guint8 *data;
@ -3531,7 +3531,7 @@ atom_trak_set_video_type (AtomTRAK * trak, AtomsContext * context,
/* QT spec has a pasp extension atom in stsd that can hold PAR */ /* QT spec has a pasp extension atom in stsd that can hold PAR */
if (par_n && (context->flavor == ATOMS_TREE_FLAVOR_MOV)) { if (par_n && (context->flavor == ATOMS_TREE_FLAVOR_MOV)) {
ste->extension_atoms = g_list_append (ste->extension_atoms, ste->extension_atoms = g_list_append (ste->extension_atoms,
build_pasp_extension (trak, par_n, par_d)); build_pasp_extension (par_n, par_d));
} }
return ste; return ste;
@ -4343,7 +4343,7 @@ build_mov_aac_extension (AtomTRAK * trak, const GstBuffer * codec_data,
} }
AtomInfo * AtomInfo *
build_mov_alac_extension (AtomTRAK * trak, const GstBuffer * codec_data) build_mov_alac_extension (const GstBuffer * codec_data)
{ {
AtomInfo *alac; AtomInfo *alac;
@ -4384,9 +4384,8 @@ build_jp2x_extension (const GstBuffer * prefix)
} }
AtomInfo * AtomInfo *
build_jp2h_extension (AtomTRAK * trak, gint width, gint height, build_jp2h_extension (gint width, gint height, const gchar * colorspace,
const gchar * colorspace, gint ncomp, const GValue * cmap_array, gint ncomp, const GValue * cmap_array, const GValue * cdef_array)
const GValue * cdef_array)
{ {
AtomData *atom_data; AtomData *atom_data;
GstBuffer *buf; GstBuffer *buf;

7
gst/isomp4/atoms.h
View file

@ -948,15 +948,14 @@ void sample_table_entry_add_ext_atom (SampleTableEntry * ste, AtomInfo * ext);
AtomInfo * build_codec_data_extension (guint32 fourcc, const GstBuffer * codec_data); AtomInfo * build_codec_data_extension (guint32 fourcc, const GstBuffer * codec_data);
AtomInfo * build_mov_aac_extension (AtomTRAK * trak, const GstBuffer * codec_data, AtomInfo * build_mov_aac_extension (AtomTRAK * trak, const GstBuffer * codec_data,
guint32 avg_bitrate, guint32 max_bitrate); guint32 avg_bitrate, guint32 max_bitrate);
AtomInfo * build_mov_alac_extension (AtomTRAK * trak, const GstBuffer * codec_data); AtomInfo * build_mov_alac_extension (const GstBuffer * codec_data);
AtomInfo * build_esds_extension (AtomTRAK * trak, guint8 object_type, AtomInfo * build_esds_extension (AtomTRAK * trak, guint8 object_type,
guint8 stream_type, const GstBuffer * codec_data, guint8 stream_type, const GstBuffer * codec_data,
guint32 avg_bitrate, guint32 max_bitrate); guint32 avg_bitrate, guint32 max_bitrate);
AtomInfo * build_btrt_extension (guint32 buffer_size_db, guint32 avg_bitrate, AtomInfo * build_btrt_extension (guint32 buffer_size_db, guint32 avg_bitrate,
guint32 max_bitrate); guint32 max_bitrate);
AtomInfo * build_jp2h_extension (AtomTRAK * trak, gint width, gint height, AtomInfo * build_jp2h_extension (gint width, gint height, const gchar *colorspace,
const gchar *colorspace, gint ncomp, gint ncomp, const GValue * cmap_array,
const GValue * cmap_array,
const GValue * cdef_array); const GValue * cdef_array);
AtomInfo * build_jp2x_extension (const GstBuffer * prefix); AtomInfo * build_jp2x_extension (const GstBuffer * prefix);

6
gst/isomp4/gstqtmux.c
View file

@ -3644,7 +3644,7 @@ gst_qt_mux_audio_sink_set_caps (GstQTPad * qtpad, GstCaps * caps)
GST_WARNING_OBJECT (qtmux, "unexpected codec-data size, possibly broken"); GST_WARNING_OBJECT (qtmux, "unexpected codec-data size, possibly broken");
} }
if (format == GST_QT_MUX_FORMAT_QT) if (format == GST_QT_MUX_FORMAT_QT)
ext_atom = build_mov_alac_extension (qtpad->trak, codec_config); ext_atom = build_mov_alac_extension (codec_config);
else else
ext_atom = build_codec_data_extension (FOURCC_alac, codec_config); ext_atom = build_codec_data_extension (FOURCC_alac, codec_config);
/* set some more info */ /* set some more info */
@ -4041,8 +4041,8 @@ gst_qt_mux_video_sink_set_caps (GstQTPad * qtpad, GstCaps * caps)
colorspace = gst_structure_get_string (structure, "colorspace"); colorspace = gst_structure_get_string (structure, "colorspace");
if (colorspace && if (colorspace &&
(ext_atom = (ext_atom =
build_jp2h_extension (qtpad->trak, width, height, colorspace, ncomp, build_jp2h_extension (width, height, colorspace, ncomp, cmap_array,
cmap_array, cdef_array)) != NULL) { cdef_array)) != NULL) {
ext_atom_list = g_list_append (ext_atom_list, ext_atom); ext_atom_list = g_list_append (ext_atom_list, ext_atom);
ext_atom = build_fiel_extension (fields); ext_atom = build_fiel_extension (fields);