mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-05 06:58:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

glcolorconvert: fix writing to subsampled yuv formats >8-bit

Browse source 
It's not quite enough to have the GstVideoInfo use a RGBA64 format, the
GstGLFormat (texture format) also needs to match as that's what actually
is used for allocation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5226>
This commit is contained in:
Matthew Waters 2023-08-23 18:33:51 +10:00 committed by GStreamer Marge Bot
parent 4c627ea2bb
commit e67bdaf4d5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gst-plugins-base/gst-libs/gst/gl/gstglcolorconvert.c
View file

@ -2892,6 +2892,7 @@ _do_convert_one_view (GstGLContext * context, GstGLColorConvert * convert,
GstAllocator *allocator; GstAllocator *allocator;
GstVideoFormat temp_format = GST_VIDEO_FORMAT_RGBA; GstVideoFormat temp_format = GST_VIDEO_FORMAT_RGBA;
GstVideoInfo temp_info; GstVideoInfo temp_info;
GstGLFormat tex_format;
if (convert->out_info.finfo->bits > 8) { if (convert->out_info.finfo->bits > 8) {
#if G_BYTE_ORDER == G_LITTLE_ENDIAN #if G_BYTE_ORDER == G_LITTLE_ENDIAN
@ -2902,11 +2903,12 @@ _do_convert_one_view (GstGLContext * context, GstGLColorConvert * convert,
} }
gst_video_info_set_format (&temp_info, temp_format, out_width, gst_video_info_set_format (&temp_info, temp_format, out_width,
out_height); out_height);
tex_format = gst_gl_format_from_video_info (context, &temp_info, 0);
allocator = gst_allocator_find (GST_GL_MEMORY_ALLOCATOR_NAME); allocator = gst_allocator_find (GST_GL_MEMORY_ALLOCATOR_NAME);
base_mem_allocator = GST_GL_BASE_MEMORY_ALLOCATOR (allocator); base_mem_allocator = GST_GL_BASE_MEMORY_ALLOCATOR (allocator);
params = gst_gl_video_allocation_params_new (context, NULL, &temp_info, params = gst_gl_video_allocation_params_new (context, NULL, &temp_info,
0, NULL, convert->priv->to_texture_target, GST_GL_RGBA); 0, NULL, convert->priv->to_texture_target, tex_format);
convert->priv->out_tex[j] = convert->priv->out_tex[j] =
(GstGLMemory *) gst_gl_base_memory_alloc (base_mem_allocator, (GstGLMemory *) gst_gl_base_memory_alloc (base_mem_allocator,