mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-28 03:00:35 +00:00
Code Issues 1 Projects Releases Wiki Activity

examples: playback-test: fix crashes when setting buffer-size

Browse source 
playbin's buffer-size property takes a gint, not a gint64,
so only pass the bits expected to the vararg function, or
the terminator might not be found, leading to crashes, esp.
with negative numbers.

Spotted by Ravi Kiran K N <ravi.kiran@samsung.com>

https://bugzilla.gnome.org/show_bug.cgi?id=729617
This commit is contained in:
Tim-Philipp Müller 2014-05-06 07:51:11 +01:00
parent bb74096870
commit e5b4e30baa
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/examples/playback/playback-test.c
View file

@ -2422,8 +2422,8 @@ buffer_size_activate_cb (GtkEntry * entry, PlaybackApp * app)
gchar *endptr;
v = g_ascii_strtoll (text, &endptr, 10);
if (endptr != text && v != G_MAXINT64 && v != G_MININT64) {
g_object_set (app->pipeline, "buffer-size", v, NULL);
if (endptr != text && v >= G_MININT && v <= G_MAXINT) {
g_object_set (app->pipeline, "buffer-size", (gint) v, NULL);
}
}
}