mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 11:32:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

vp8dec: Fix memory leak

Browse source
This commit is contained in:
Sebastian Dröge 2010-05-19 23:02:19 +02:00
parent 9b0cd2ef95
commit e3925075f9
1 changed files with 6 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
ext/vp8/gstvp8dec.c
View file

@ -409,7 +409,7 @@ static GstFlowReturn
gst_vp8_dec_handle_frame (GstBaseVideoDecoder * decoder, GstVideoFrame * frame) gst_vp8_dec_handle_frame (GstBaseVideoDecoder * decoder, GstVideoFrame * frame)
{ {
GstVP8Dec *dec; GstVP8Dec *dec;
GstFlowReturn ret; GstFlowReturn ret = GST_FLOW_OK;
vpx_codec_err_t status; vpx_codec_err_t status;
vpx_codec_iter_t iter = NULL; vpx_codec_iter_t iter = NULL;
vpx_image_t *img; vpx_image_t *img;
@ -488,13 +488,6 @@ gst_vp8_dec_handle_frame (GstBaseVideoDecoder * decoder, GstVideoFrame * frame)
} }
#endif #endif
ret = gst_base_video_decoder_alloc_src_frame (decoder, frame);
if (ret != GST_FLOW_OK) {
GST_WARNING_OBJECT (decoder, "failed to get buffer: %s",
gst_flow_get_name (ret));
goto out;
}
status = vpx_codec_decode (&dec->decoder, status = vpx_codec_decode (&dec->decoder,
GST_BUFFER_DATA (frame->sink_buffer), GST_BUFFER_DATA (frame->sink_buffer),
GST_BUFFER_SIZE (frame->sink_buffer), NULL, 0); GST_BUFFER_SIZE (frame->sink_buffer), NULL, 0);
@ -506,13 +499,14 @@ gst_vp8_dec_handle_frame (GstBaseVideoDecoder * decoder, GstVideoFrame * frame)
img = vpx_codec_get_frame (&dec->decoder, &iter); img = vpx_codec_get_frame (&dec->decoder, &iter);
if (img) { if (img) {
ret = gst_base_video_decoder_alloc_src_frame (decoder, frame); ret = gst_base_video_decoder_alloc_src_frame (decoder, frame);
if (ret == GST_FLOW_OK) if (ret == GST_FLOW_OK) {
gst_vp8_dec_image_to_buffer (dec, img, frame->src_buffer); gst_vp8_dec_image_to_buffer (dec, img, frame->src_buffer);
gst_base_video_decoder_finish_frame (decoder, frame);
gst_base_video_decoder_finish_frame (decoder, frame); } else {
gst_base_video_decoder_skip_frame (decoder, frame);
}
vpx_img_free (img); vpx_img_free (img);
@ -524,7 +518,6 @@ gst_vp8_dec_handle_frame (GstBaseVideoDecoder * decoder, GstVideoFrame * frame)
/* Invisible frame */ /* Invisible frame */
gst_base_video_decoder_skip_frame (decoder, frame); gst_base_video_decoder_skip_frame (decoder, frame);
} }
out:
return ret; return ret;
} }