mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 17:20:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

h265parse: Fix buffer leak when sps is not present

Browse source 
When sps data is NULL, the buffer allocated and mapped is not being freed.
In this scenario there is no need to allocate the buffer as we are supposed to return NULL.

https://bugzilla.gnome.org/show_bug.cgi?id=761070
This commit is contained in:
Vineeth TM 2016-01-25 13:33:09 +09:00 committed by Thiago Santos
parent 6a35a4018e
commit e389211aa5
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/videoparsers/gsth265parse.c
View file

@ -1073,6 +1073,10 @@ gst_h265_parse_make_codec_data (GstH265Parse * h265parse)
if (!found)
return NULL;
sps = h265parse->nalparser->last_sps;
if (!sps)
return NULL;
buf =
gst_buffer_new_allocate (NULL,
23 + num_arrays + (3 * num_arrays) + vps_size + sps_size + pps_size,
@ -1082,9 +1086,6 @@ gst_h265_parse_make_codec_data (GstH265Parse * h265parse)
memset (data, 0, map.size);
nl = h265parse->nal_length_size;
sps = h265parse->nalparser->last_sps;
if (!sps)
return NULL;
pft = &sps->profile_tier_level;
if (sps->vui_parameters_present_flag)
min_spatial_segmentation_idc = sps->vui_params.min_spatial_segmentation_idc;