mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-05 18:22:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

souphttpsink: Fix refcounting of the "session" property

Browse source 
Properties should never take ownership of the values
passed to them.
This commit is contained in:
Sebastian Dröge 2011-06-02 10:41:52 +02:00
parent 0672232b26
commit e376913fc3
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ext/soup/gstsouphttpsink.c
View file

@ -249,7 +249,7 @@ gst_soup_http_sink_set_property (GObject * object, guint property_id,
if (souphttpsink->prop_session) { if (souphttpsink->prop_session) {
g_object_unref (souphttpsink->prop_session); g_object_unref (souphttpsink->prop_session);
} }
souphttpsink->prop_session = g_value_get_object (value); souphttpsink->prop_session = g_value_dup_object (value);
break; break;
case PROP_LOCATION: case PROP_LOCATION:
g_free (souphttpsink->location); g_free (souphttpsink->location);
@ -327,9 +327,12 @@ gst_soup_http_sink_get_property (GObject * object, guint property_id,
void void
gst_soup_http_sink_dispose (GObject * object) gst_soup_http_sink_dispose (GObject * object)
{ {
/* GstSoupHttpSink *souphttpsink = GST_SOUP_HTTP_SINK (object); */ GstSoupHttpSink *souphttpsink = GST_SOUP_HTTP_SINK (object);
/* clean up as possible. may be called multiple times */ /* clean up as possible. may be called multiple times */
if (souphttpsink->prop_session)
g_object_unref (souphttpsink->prop_session);
souphttpsink->prop_session = NULL;
G_OBJECT_CLASS (parent_class)->dispose (object); G_OBJECT_CLASS (parent_class)->dispose (object);
} }