mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-08 18:39:54 +00:00
Code Issues 1 Projects Releases Wiki Activity

debugutils: Skip multiqueue stats in dot dump

Browse source 
If this is not done, tools like xdot fail with "unexpected char
b'\\'". This is a regression caused by commit
74938f07c2 (multiqueue: Add stats
property).

The deserialized value coming out of g_object_get_property looks like
this,

$24 = (gchar *) 0x7f560c0046a0 "application/x-gst-multi-queue-stats, queues=(structure)< \\\"queue_0\\\\,\\\\ buffers\\\\=\\\\(uint\\\\)39\\\\,\\\\ bytes\\\\=\\\\(uint\\\\)8
120251\\\\,\\\\ time\\\\=\\\\(guint64\\\\)1460000000\\\\;\\\", \\\"queue_1\\\\,\\\\ buffers\\\\=\\\\(uint\\\\)186\\\\,\\\\ bytes\\\\=\\\\(uint\\\\)838020\\\\,\\\\ time\\\\=\
\\\(guint64\\\\)1984000002\\\\;\\\" >;"

That is immediately looking wrong. I don't know enough about GNOME
serialization details to say with confidence what happened here. It
gets worse after this is sent through g_strescape and then written to
the dot file. Interestingly, dot -Tpng is fine to ignore them it
seems.

Since the stats are by definition verbose, I decided the best choice
to omit them from the dot file, since such details are not of interest
there.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/442>
This commit is contained in:
Charlie Turner 2020-04-21 18:14:00 +01:00 committed by GStreamer Merge Bot
parent ed1022fa81
commit e310a738f6
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst/gstdebugutils.c
View file

@ -614,6 +614,7 @@ debug_dump_element (GstBin * bin, GstDebugGraphDetails details,
gchar *state_name = NULL;
gchar *param_name = NULL;
const gchar *spc = MAKE_INDENT (indent);
static const char *const ignore_propnames[] = { "stats", NULL };
element_iter = gst_bin_iterate_elements (bin);
elements_done = FALSE;
@ -628,7 +629,7 @@ debug_dump_element (GstBin * bin, GstDebugGraphDetails details,
}
if (details & GST_DEBUG_GRAPH_SHOW_NON_DEFAULT_PARAMS) {
param_name = debug_dump_get_object_params (G_OBJECT (element),
details, NULL);
details, ignore_propnames);
}
/* elements */
g_string_append_printf (str, "%ssubgraph cluster_%s {\n", spc,