mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 11:45:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

Have strict version check for OpenH264 to avoid ABI issues

Browse source 
This fixes #1274 and no longer trusts soname alone

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1206>
This commit is contained in:
Seppo Yli-Olli 2020-04-21 13:33:54 +03:00 committed by GStreamer Merge Bot
parent 2fe473fa50
commit e2aa76db79
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
ext/openh264/gstopenh264plugin.c
View file

@ -32,17 +32,29 @@
#endif
#include <gst/gst.h>
#include <wels/codec_api.h>
#include <wels/codec_ver.h>
#include <string.h>
#include "gstopenh264dec.h"
#include "gstopenh264enc.h"
static gboolean
plugin_init (GstPlugin * plugin)
{
gst_element_register (plugin, "openh264dec", GST_RANK_MARGINAL,
GST_TYPE_OPENH264DEC);
gst_element_register (plugin, "openh264enc", GST_RANK_MARGINAL,
GST_TYPE_OPENH264ENC);
/* g_stCodecVersion is the version detected at build time as defined in the
* headers and WelsGetCodecVersion() is the version detected at runtime.
* This is a safeguard to avoid crashes since OpenH264 has been changing
* ABI without changing the SONAME.
*/
OpenH264Version libver = WelsGetCodecVersion ();
if (memcmp (&libver, &g_stCodecVersion, sizeof (libver))) {
gst_element_register (plugin, "openh264dec", GST_RANK_MARGINAL,
GST_TYPE_OPENH264DEC);
gst_element_register (plugin, "openh264enc", GST_RANK_MARGINAL,
GST_TYPE_OPENH264ENC);
} else {
GST_ERROR ("Incorrect library version loaded, expecting %s", g_strCodecVer);
}
return TRUE;
}