mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 22:16:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpvp8depay: potential access beyond end of array

Browse source 
Compiling (with gcc-4.9-20150603) produces an error because of an access beyond
the end of an array. This patch fixes the error by initializing the loop
control/array index variable (i) to 1 and returning i - 1 when a match is found.
Also, because the values stored in the array increase in value as the index
increases, the >= test unnecessary, so it is removed.
This commit is contained in:
Chris Clayton 2015-06-08 19:42:30 +01:00 committed by Luis de Bethencourt
parent d78502deb1
commit e29f231e5d
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/rtp/gstrtpvp8pay.c
View file

@ -350,13 +350,12 @@ gst_rtp_vp8_offset_to_partition (GstRtpVP8Pay * self, guint offset)
{
int i;
for (i = 0; i < self->n_partitions; i++) {
if (offset >= self->partition_offset[i] &&
offset < self->partition_offset[i + 1])
return i;
for (i = 1; i < self->n_partitions; i++) {
if (offset < self->partition_offset[i])
return i - 1;
}
return i;
return i - 1;
}
static gsize