mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-19 22:05:58 +00:00
Code Issues 1 Projects Releases Wiki Activity

basetransform: rework accept-caps

Browse source 
According to the design docs:
The ACCEPT_CAPS query is not required to work recursively, it can simply
return TRUE if a subsequent CAPS event with those caps would return
success.

So make it a shallow check instead of recursivelly check downstream.

https://bugzilla.gnome.org/show_bug.cgi?id=748635
This commit is contained in:
Thiago Santos 2015-08-13 13:08:03 -03:00
parent 42acf05b22
commit e0cc0e0888
1 changed files with 28 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
libs/gst/base/gstbasetransform.c
View file

@ -1285,46 +1285,51 @@ static gboolean
gst_base_transform_acceptcaps_default (GstBaseTransform * trans,
GstPadDirection direction, GstCaps * caps)
{
GstPad *pad;
GstCaps *allowed;
GstPad *pad, *otherpad;
GstCaps *templ, *otempl, *ocaps = NULL;
gboolean ret = TRUE;
pad =
(direction ==
GST_PAD_SINK) ? GST_BASE_TRANSFORM_SINK_PAD (trans) :
GST_BASE_TRANSFORM_SRC_PAD (trans);
otherpad =
(direction ==
GST_PAD_SINK) ? GST_BASE_TRANSFORM_SRC_PAD (trans) :
GST_BASE_TRANSFORM_SINK_PAD (trans);
GST_DEBUG_OBJECT (trans, "accept caps %" GST_PTR_FORMAT, caps);
templ = gst_pad_get_pad_template_caps (pad);
otempl = gst_pad_get_pad_template_caps (otherpad);
/* get all the formats we can handle on this pad */
allowed = gst_pad_query_caps (pad, caps);
if (!allowed) {
GST_DEBUG_OBJECT (trans, "gst_pad_query_caps() failed");
goto no_transform_possible;
}
GST_DEBUG_OBJECT (trans, "intersect with pad template: %" GST_PTR_FORMAT,
templ);
if (!gst_caps_can_intersect (caps, templ))
goto reject_caps;
GST_DEBUG_OBJECT (trans, "allowed caps %" GST_PTR_FORMAT, allowed);
/* intersect with the requested format */
if (GST_PAD_IS_ACCEPT_INTERSECT (pad)) {
GST_DEBUG_OBJECT (pad,
"allowed caps intersect %" GST_PTR_FORMAT ", caps %" GST_PTR_FORMAT,
allowed, caps);
ret = gst_caps_can_intersect (caps, allowed);
} else {
GST_DEBUG_OBJECT (pad, "allowed caps subset %" GST_PTR_FORMAT ", caps %"
GST_PTR_FORMAT, allowed, caps);
ret = gst_caps_is_subset (caps, allowed);
}
gst_caps_unref (allowed);
if (!ret)
GST_DEBUG_OBJECT (trans, "trying to transform with filter: %"
GST_PTR_FORMAT " (the other pad template)", otempl);
ocaps = gst_base_transform_transform_caps (trans, direction, caps, otempl);
if (!ocaps || gst_caps_is_empty (ocaps))
goto no_transform_possible;
done:
GST_DEBUG_OBJECT (trans, "accept-caps result: %d", ret);
if (ocaps)
gst_caps_unref (ocaps);
gst_caps_unref (templ);
gst_caps_unref (otempl);
return ret;
/* ERRORS */
reject_caps:
{
GST_DEBUG_OBJECT (trans, "caps can't intersect with the template");
ret = FALSE;
goto done;
}
no_transform_possible:
{
GST_DEBUG_OBJECT (trans,