mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-16 19:25:18 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: vpp: Use gst_caps_replace to operate the filter_caps

Browse source 
No need to use lock when we assign value to priv->filter_caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7547>
This commit is contained in:
He Junyan 2024-09-06 23:35:59 +08:00 committed by GStreamer Marge Bot
parent 9c0fbfd2eb
commit dfccbd52f4
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c
View file

@ -881,20 +881,25 @@ bail:
GstCaps * GstCaps *
gst_va_base_transform_get_filter_caps (GstVaBaseTransform * self) gst_va_base_transform_get_filter_caps (GstVaBaseTransform * self)
{ {
GstCaps *ret = NULL;
g_return_val_if_fail (GST_IS_VA_BASE_TRANSFORM (self), NULL); g_return_val_if_fail (GST_IS_VA_BASE_TRANSFORM (self), NULL);
GST_OBJECT_LOCK (self); gst_caps_replace (&ret, self->priv->filter_caps);
if (self->priv->filter_caps) {
GST_OBJECT_UNLOCK (self); if (ret) {
return self->priv->filter_caps; /* Release the extra reference. */
gst_caps_unref (ret);
return ret;
} }
GST_OBJECT_UNLOCK (self);
if (!self->filter) if (!self->filter)
return NULL; return NULL;
GST_OBJECT_LOCK (self); ret = gst_va_filter_get_caps (self->filter);
self->priv->filter_caps = gst_va_filter_get_caps (self->filter); /* We do not cmp and assign here, just use our new value. */
GST_OBJECT_UNLOCK (self); gst_caps_replace (&self->priv->filter_caps, ret);
return self->priv->filter_caps; /* Release the extra got reference. */
gst_caps_unref (ret);
return ret;
} }