mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-16 04:15:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

identity: Don't refuse seeks unless single-segment=true

Browse source 
identity only needs to configure the internal seek segment if it's
aggregating upstream segments into 1. If it's not, don't break
other seek behaviour by refusing (for example) instant-rate change
seeks.

Fixes: #3363
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6307>
This commit is contained in:
Jan Schmidt 2024-03-08 17:05:34 +11:00 committed by Tim-Philipp Müller
parent 6f21f90747
commit dea8b1cb37
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gstreamer/plugins/elements/gstidentity.c
View file

@ -569,15 +569,17 @@ gst_identity_src_event (GstBaseTransform * trans, GstEvent * event)
&start, &stop_type, &stop); &start, &stop_type, &stop);
GST_OBJECT_LOCK (identity); GST_OBJECT_LOCK (identity);
if (identity->single_segment) {
gst_segment_init (&identity->seek_segment, fmt); gst_segment_init (&identity->seek_segment, fmt);
if (!gst_segment_do_seek (&identity->seek_segment, rate, fmt, if (!gst_segment_do_seek (&identity->seek_segment, rate, fmt,
flags, start_type, start, stop_type, stop, NULL)) { flags, start_type, start, stop_type, stop, NULL)) {
GST_WARNING_OBJECT (identity, "Could not run seek %" GST_PTR_FORMAT, GST_WARNING_OBJECT (identity, "Could not handle %" GST_PTR_FORMAT,
event); event);
GST_OBJECT_UNLOCK (identity); GST_OBJECT_UNLOCK (identity);
return FALSE; return FALSE;
} }
}
GST_OBJECT_UNLOCK (identity); GST_OBJECT_UNLOCK (identity);
break; break;