mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-07 06:52:41 +00:00
Code Issues 1 Projects Releases Wiki Activity

xdgmime: Add locking to the xdg_mime_* calls as it's not thread-safe

Browse source
This commit is contained in:
Sebastian Dröge 2009-03-02 16:27:55 +01:00
parent f957ee0aeb
commit de61b45025
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/xdgmime/gstxdgmime.c
View file

@ -26,6 +26,8 @@
GST_DEBUG_CATEGORY (xdgmime_debug); GST_DEBUG_CATEGORY (xdgmime_debug);
#define GST_CAT_DEFAULT xdgmime_debug #define GST_CAT_DEFAULT xdgmime_debug
G_LOCK_DEFINE_STATIC (xdg_lock);
static void static void
xdgmime_typefind (GstTypeFind * find, gpointer user_data) xdgmime_typefind (GstTypeFind * find, gpointer user_data)
{ {
@ -42,7 +44,14 @@ xdgmime_typefind (GstTypeFind * find, gpointer user_data)
if ((data = gst_type_find_peek (find, 0, length)) == NULL) if ((data = gst_type_find_peek (find, 0, length)) == NULL)
return; return;
/* FIXME: xdg-mime is not thread-safe as it stores the cache globally
* and updates it from every call if changes were done without
* any locking
*/
G_LOCK (xdg_lock);
mimetype = xdg_mime_get_mime_type_for_data (data, length, &prio); mimetype = xdg_mime_get_mime_type_for_data (data, length, &prio);
G_UNLOCK (xdg_lock);
if (mimetype == NULL || g_str_equal (mimetype, XDG_MIME_TYPE_UNKNOWN)) if (mimetype == NULL || g_str_equal (mimetype, XDG_MIME_TYPE_UNKNOWN))
return; return;