mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-28 20:51:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

pad-monitor: only do complete caps checks on setcaps

Browse source 
On get caps it is acceptable to have missing fields to simplify caps
negotiation
This commit is contained in:
Thiago Santos 2013-08-14 15:58:34 -03:00
parent 848c86712b
commit ddc95f5b8c
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
validate/gst/qa/gst-qa-pad-monitor.c
View file

@ -1526,7 +1526,6 @@ gst_qa_pad_monitor_getcaps_func (GstPad * pad)
/* We shouldn't need to lock the parent as this doesn't modify /* We shouldn't need to lock the parent as this doesn't modify
* other monitors, just does some peer_pad_caps */ * other monitors, just does some peer_pad_caps */
GST_QA_MONITOR_LOCK (pad_monitor); GST_QA_MONITOR_LOCK (pad_monitor);
gst_qa_pad_monitor_check_caps_complete (pad_monitor, ret);
if (GST_PAD_DIRECTION (pad) == GST_PAD_SINK) { if (GST_PAD_DIRECTION (pad) == GST_PAD_SINK) {
gst_qa_pad_monitor_check_caps_fields_proxied (pad_monitor, ret); gst_qa_pad_monitor_check_caps_fields_proxied (pad_monitor, ret);
@ -1550,6 +1549,8 @@ gst_qa_pad_monitor_setcaps_func (GstPad * pad, GstCaps * caps)
GST_QA_PAD_MONITOR_PARENT_LOCK (pad_monitor); GST_QA_PAD_MONITOR_PARENT_LOCK (pad_monitor);
GST_QA_MONITOR_LOCK (pad_monitor); GST_QA_MONITOR_LOCK (pad_monitor);
gst_qa_pad_monitor_check_caps_complete (pad_monitor, caps);
if (caps) { if (caps) {
structure = gst_caps_get_structure (caps, 0); structure = gst_caps_get_structure (caps, 0);
if (gst_structure_n_fields (pad_monitor->pending_setcaps_fields)) { if (gst_structure_n_fields (pad_monitor->pending_setcaps_fields)) {