mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstvalue: Optimize list subset some more

Browse source 
Avoid going through the double subtract function when comparing
anything to a list.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/453>
This commit is contained in:
Edward Hervey 2020-03-23 17:03:51 +01:00 committed by Sebastian Dröge
parent 46449cbb76
commit dc7efe296d
1 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
gst/gstvalue.c
View file

@ -4303,6 +4303,25 @@ gst_value_is_subset_list_list (const GValue * value1, const GValue * value2)
return TRUE; return TRUE;
} }
static gboolean
gst_value_is_subset_list (const GValue * value1, const GValue * value2)
{
GstValueList *vlist2 = VALUE_LIST_ARRAY (value2);
gint it2, len2;
len2 = vlist2->len;
/* Check whether value1 is within the list */
for (it2 = 0; it2 < len2; it2++) {
const GValue *child2 = &vlist2->fields[it2];
if (gst_value_compare (value1, child2) == GST_VALUE_EQUAL) {
return TRUE;
}
}
return FALSE;
}
/** /**
* gst_value_is_subset: * gst_value_is_subset:
* @value1: a #GValue * @value1: a #GValue
@ -4315,6 +4334,9 @@ gst_value_is_subset_list_list (const GValue * value1, const GValue * value2)
gboolean gboolean
gst_value_is_subset (const GValue * value1, const GValue * value2) gst_value_is_subset (const GValue * value1, const GValue * value2)
{ {
GType type1 = G_VALUE_TYPE (value1);
GType type2 = G_VALUE_TYPE (value2);
/* special case for int/int64 ranges, since we cannot compute /* special case for int/int64 ranges, since we cannot compute
the difference for those when they have different steps, the difference for those when they have different steps,
and it's actually a lot simpler to compute whether a range and it's actually a lot simpler to compute whether a range
@ -4330,8 +4352,10 @@ gst_value_is_subset (const GValue * value1, const GValue * value2)
} else if (GST_VALUE_HOLDS_STRUCTURE (value1) } else if (GST_VALUE_HOLDS_STRUCTURE (value1)
&& GST_VALUE_HOLDS_STRUCTURE (value2)) { && GST_VALUE_HOLDS_STRUCTURE (value2)) {
return gst_value_is_subset_structure_structure (value1, value2); return gst_value_is_subset_structure_structure (value1, value2);
} else if (GST_VALUE_HOLDS_LIST (value1) && GST_VALUE_HOLDS_LIST (value2)) { } else if (type2 == GST_TYPE_LIST) {
return gst_value_is_subset_list_list (value1, value2); if (type1 == GST_TYPE_LIST)
return gst_value_is_subset_list_list (value1, value2);
return gst_value_is_subset_list (value1, value2);
} }
/* /*