ext/mpeg2dec/gstmpeg2dec.c: Fix minor memleak when creating pads from static pad templates (#369627).

Original commit message from CVS:
Patch by: Sebastian Dröge  <slomo@circular-chaos.org>
* ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_init):
Fix minor memleak when creating pads from static pad templates (#369627).
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/mpeg2dec.c: (setup_mpeg2dec),
(cleanup_mpeg2dec), (GST_START_TEST), (mpeg2dec_suite), (main):
Add unit tests for mpeg2dec (#369627).
This commit is contained in:
Sebastian Dröge 2006-11-15 11:41:39 +00:00 committed by Tim-Philipp Müller
parent e67fed6acc
commit dc26edbddf
5 changed files with 1600 additions and 7 deletions

View file

@ -1,3 +1,16 @@
2006-11-15 Tim-Philipp Müller <tim at centricular dot net>
Patch by: Sebastian Dröge <slomo@circular-chaos.org>
* ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_init):
Fix minor memleak when creating pads from static pad templates (#369627).
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/mpeg2dec.c: (setup_mpeg2dec),
(cleanup_mpeg2dec), (GST_START_TEST), (mpeg2dec_suite), (main):
Add unit tests for mpeg2dec (#369627).
2006-11-14 Wim Taymans <wim@fluendo.com> 2006-11-14 Wim Taymans <wim@fluendo.com>
Patch by: Mark Nauwelaerts <manauw at skynet be> Patch by: Mark Nauwelaerts <manauw at skynet be>

View file

@ -215,8 +215,7 @@ gst_mpeg2dec_init (GstMpeg2dec * mpeg2dec)
{ {
/* create the sink and src pads */ /* create the sink and src pads */
mpeg2dec->sinkpad = mpeg2dec->sinkpad =
gst_pad_new_from_template (gst_static_pad_template_get gst_pad_new_from_static_template (&sink_template_factory, "sink");
(&sink_template_factory), "sink");
gst_pad_set_chain_function (mpeg2dec->sinkpad, gst_pad_set_chain_function (mpeg2dec->sinkpad,
GST_DEBUG_FUNCPTR (gst_mpeg2dec_chain)); GST_DEBUG_FUNCPTR (gst_mpeg2dec_chain));
#if 0 #if 0
@ -228,8 +227,7 @@ gst_mpeg2dec_init (GstMpeg2dec * mpeg2dec)
gst_element_add_pad (GST_ELEMENT (mpeg2dec), mpeg2dec->sinkpad); gst_element_add_pad (GST_ELEMENT (mpeg2dec), mpeg2dec->sinkpad);
mpeg2dec->srcpad = mpeg2dec->srcpad =
gst_pad_new_from_template (gst_static_pad_template_get gst_pad_new_from_static_template (&src_template_factory, "src");
(&src_template_factory), "src");
gst_pad_set_event_function (mpeg2dec->srcpad, gst_pad_set_event_function (mpeg2dec->srcpad,
GST_DEBUG_FUNCPTR (gst_mpeg2dec_src_event)); GST_DEBUG_FUNCPTR (gst_mpeg2dec_src_event));
gst_pad_set_query_type_function (mpeg2dec->srcpad, gst_pad_set_query_type_function (mpeg2dec->srcpad,
@ -241,8 +239,8 @@ gst_mpeg2dec_init (GstMpeg2dec * mpeg2dec)
#ifdef enable_user_data #ifdef enable_user_data
mpeg2dec->userdatapad = mpeg2dec->userdatapad =
gst_pad_new_from_template (gst_static_pad_template_get gst_pad_new_from_static_template (&user_data_template_factory,
(&user_data_template_factory), "user_data"); "user_data");
gst_element_add_pad (GST_ELEMENT (mpeg2dec), mpeg2dec->userdatapad); gst_element_add_pad (GST_ELEMENT (mpeg2dec), mpeg2dec->userdatapad);
#endif #endif

View file

@ -23,8 +23,15 @@ else
AMRNB = AMRNB =
endif endif
if USE_MPEG2DEC
MPEG2DEC = elements/mpeg2dec
else
MPEG2DEC =
endif
check_PROGRAMS = \ check_PROGRAMS = \
$(AMRNB) $(AMRNB) \
$(MPEG2DEC)
# these tests don't even pass # these tests don't even pass
noinst_PROGRAMS = noinst_PROGRAMS =

View file

@ -1,2 +1,3 @@
amrnbenc amrnbenc
mpeg2dec
.dirstamp .dirstamp

File diff suppressed because it is too large Load diff