mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 06:46:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

ximagesink: fix navigation event leak

Browse source 
Create event only when pad is created
and send the event to pad.

https://bugzilla.gnome.org/show_bug.cgi?id=752041
This commit is contained in:
Vineeth T M 2015-07-07 19:35:40 +09:00 committed by Luis de Bethencourt
parent cf454ca713
commit db86c73f4d
1 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sys/ximage/ximagesink.c
View file

@ -1525,12 +1525,9 @@ gst_x_image_sink_navigation_send_event (GstNavigation * navigation,
GstStructure * structure) GstStructure * structure)
{ {
GstXImageSink *ximagesink = GST_X_IMAGE_SINK (navigation); GstXImageSink *ximagesink = GST_X_IMAGE_SINK (navigation);
GstEvent *event; GstEvent *event = NULL;
gint x_offset, y_offset; gint x_offset, y_offset;
gdouble x, y; gdouble x, y;
GstPad *pad = NULL;
event = gst_event_new_navigation (structure);
/* We are not converting the pointer coordinates as there's no hardware /* We are not converting the pointer coordinates as there's no hardware
scaling done here. The only possible scaling is done by videoscale and scaling done here. The only possible scaling is done by videoscale and
@ -1560,13 +1557,9 @@ gst_x_image_sink_navigation_send_event (GstNavigation * navigation,
gst_structure_set (structure, "pointer_y", G_TYPE_DOUBLE, y, NULL); gst_structure_set (structure, "pointer_y", G_TYPE_DOUBLE, y, NULL);
} }
pad = gst_pad_get_peer (GST_VIDEO_SINK_PAD (ximagesink)); event = gst_event_new_navigation (structure);
if (event)
if (GST_IS_PAD (pad) && GST_IS_EVENT (event)) { gst_pad_push_event (GST_VIDEO_SINK_PAD (ximagesink), event);
gst_pad_send_event (pad, event);
gst_object_unref (pad);
}
} }
static void static void