mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

miniobject: delay private data initialisation until actually needed

Browse source 
We only use the private instance data for weak references for now,
so can delay initialisation until actually needed (microoptimisation)
This commit is contained in:
Tim-Philipp Müller 2011-05-16 13:39:25 +01:00
parent b4dea3a1d3
commit da21881f28
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
gst/gstminiobject.c
View file

@ -172,13 +172,8 @@ gst_mini_object_init (GTypeInstance * instance, gpointer klass)
mini_object->refcount = 1; mini_object->refcount = 1;
/* Initialize the mini object's private data */ /* we delay initialising the mini object's private data until it's actually
* needed for now (mini_object->priv automatically inited to NULL) */
mini_object->priv = (GstMiniObjectPrivate *)
G_TYPE_INSTANCE_GET_PRIVATE (instance, GST_TYPE_MINI_OBJECT,
GstMiniObjectPrivate);
mini_object->priv->wstack = NULL;
} }
static GstMiniObject * static GstMiniObject *
@ -384,7 +379,7 @@ gst_mini_object_free (GstMiniObject * mini_object)
* want to free the instance anymore */ * want to free the instance anymore */
if (G_LIKELY (g_atomic_int_dec_and_test (&mini_object->refcount))) { if (G_LIKELY (g_atomic_int_dec_and_test (&mini_object->refcount))) {
/* The weak reference stack is freed in the notification function */ /* The weak reference stack is freed in the notification function */
if (mini_object->priv->wstack) if (mini_object->priv != NULL && mini_object->priv->wstack != NULL)
weak_refs_notify (mini_object->priv->wstack); weak_refs_notify (mini_object->priv->wstack);
#ifndef GST_DISABLE_TRACE #ifndef GST_DISABLE_TRACE
@ -444,6 +439,13 @@ gst_mini_object_weak_ref (GstMiniObject * object,
G_LOCK (weak_refs_mutex); G_LOCK (weak_refs_mutex);
if (object->priv == NULL) {
object->priv = G_TYPE_INSTANCE_GET_PRIVATE (object, GST_TYPE_MINI_OBJECT,
GstMiniObjectPrivate);
/* object->priv->wstack will have been inited to NULL automatically */
}
if (object->priv->wstack) { if (object->priv->wstack) {
/* Don't add the weak reference if it already exists. */ /* Don't add the weak reference if it already exists. */
for (i = 0; i < object->priv->wstack->n_weak_refs; i++) { for (i = 0; i < object->priv->wstack->n_weak_refs; i++) {
@ -492,7 +494,7 @@ gst_mini_object_weak_unref (GstMiniObject * object,
G_LOCK (weak_refs_mutex); G_LOCK (weak_refs_mutex);
if (object->priv->wstack) { if (object->priv != NULL && object->priv->wstack != NULL) {
guint i; guint i;
for (i = 0; i < object->priv->wstack->n_weak_refs; i++) for (i = 0; i < object->priv->wstack->n_weak_refs; i++)