mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 16:08:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

g_critical is a glib-2.0-ism, changed them to g_warning and added FIXME's

Browse source 
Original commit message from CVS:
g_critical is a glib-2.0-ism, changed them to g_warning and added FIXME's
This commit is contained in:
Thomas Vander Stichele 2001-09-23 08:26:10 +00:00
parent 7a556d4a3d
commit d938af0175
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/gstelementfactory.c
View file

@ -196,8 +196,10 @@ gst_elementfactory_new (const gchar *name, GType type,
if (!factory->type) if (!factory->type)
factory->type = type; factory->type = type;
else if (factory->type != type) else if (factory->type != type)
/* FIXME: g_critical is glib-2.0, not glib-1.2
g_critical ("`%s' requested type change (!)", name); g_critical ("`%s' requested type change (!)", name);
*/
g_warning ("`%s' requested type change (!)", name);
gst_object_set_name (GST_OBJECT (factory), name); gst_object_set_name (GST_OBJECT (factory), name);
return factory; return factory;
@ -231,7 +233,10 @@ gst_elementfactory_create (GstElementFactory *factory,
if (factory->type == 0) if (factory->type == 0)
{ {
/* FIXME: g_critical is glib-2.0, not glib-1.2
g_critical ("Factory for `%s' has no type", g_critical ("Factory for `%s' has no type",
*/
g_warning ("Factory for `%s' has no type",
gst_object_get_name (GST_OBJECT (factory))); gst_object_get_name (GST_OBJECT (factory)));
return NULL; return NULL;
} }

6
gst/gstpad.c
View file

@ -566,7 +566,10 @@ gst_pad_connect (GstPad *srcpad,
GstPad *sinkpad) GstPad *sinkpad)
{ {
if (!gst_pad_try_connect (srcpad, sinkpad)) if (!gst_pad_try_connect (srcpad, sinkpad))
/* FIXME: g_critical is glib-2.0, not glib-1.2
g_critical ("couldn't connect %s:%s and %s:%s", g_critical ("couldn't connect %s:%s and %s:%s",
*/
g_warning ("couldn't connect %s:%s and %s:%s",
GST_DEBUG_PAD_NAME (srcpad), GST_DEBUG_PAD_NAME (srcpad),
GST_DEBUG_PAD_NAME (sinkpad)); GST_DEBUG_PAD_NAME (sinkpad));
} }
@ -1476,7 +1479,10 @@ gst_pad_pull (GstPad *pad)
if (!peer) if (!peer)
{ {
/* FIXME: g_critical is glib-2.0, not glib-1.2
g_critical ("gst_pad_pull but %s:%s is unconnected", GST_DEBUG_PAD_NAME(pad)); g_critical ("gst_pad_pull but %s:%s is unconnected", GST_DEBUG_PAD_NAME(pad));
*/
g_warning ("gst_pad_pull but %s:%s is unconnected", GST_DEBUG_PAD_NAME(pad));
return NULL; return NULL;
} }