mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

wpe: Plug a leak

Browse source 
We were freeing after returning

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2273>
This commit is contained in:
Thibault Saunier 2021-05-21 10:13:01 -04:00
parent ca1812f38c
commit d93131bfee
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/wpe/gstwpesrcbin.cpp
View file

@ -169,7 +169,7 @@ G_DEFINE_TYPE_WITH_CODE (GstWpeSrc, gst_wpe_src, GST_TYPE_BIN,
* GstWpeSrc!video * GstWpeSrc!video
* *
* Since: 1.20 * Since: 1.20
*/ */
static GstStaticPadTemplate video_src_factory = static GstStaticPadTemplate video_src_factory =
GST_STATIC_PAD_TEMPLATE ("video", GST_PAD_SRC, GST_PAD_SOMETIMES, GST_STATIC_PAD_TEMPLATE ("video", GST_PAD_SRC, GST_PAD_SOMETIMES,
GST_STATIC_CAPS ("video/x-raw(memory:GLMemory), " GST_STATIC_CAPS ("video/x-raw(memory:GLMemory), "
@ -194,7 +194,7 @@ GST_STATIC_PAD_TEMPLATE ("video", GST_PAD_SRC, GST_PAD_SOMETIMES,
* #GstPad. * #GstPad.
* *
* Since: 1.20 * Since: 1.20
*/ */
static GstStaticPadTemplate audio_src_factory = static GstStaticPadTemplate audio_src_factory =
GST_STATIC_PAD_TEMPLATE ("audio_%u", GST_PAD_SRC, GST_PAD_SOMETIMES, GST_STATIC_PAD_TEMPLATE ("audio_%u", GST_PAD_SRC, GST_PAD_SOMETIMES,
GST_STATIC_CAPS ( \ GST_STATIC_CAPS ( \

6
ext/wpe/wpe-extension/gstwpebusmsgforwarder.c
View file

@ -44,6 +44,7 @@ create_gerror_bus_msg (GstElement * element, GstMessage * message)
{ {
GError *error; GError *error;
gchar *debug_str, *details_structure, *src_path; gchar *debug_str, *details_structure, *src_path;
WebKitUserMessage *msg;
const GstStructure *details = NULL; const GstStructure *details = NULL;
if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ERROR) { if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ERROR) {
@ -60,7 +61,8 @@ create_gerror_bus_msg (GstElement * element, GstMessage * message)
details_structure = details_structure =
details ? gst_structure_to_string (details) : g_strdup (""); details ? gst_structure_to_string (details) : g_strdup ("");
src_path = gst_object_get_path_string (GST_MESSAGE_SRC (message)); src_path = gst_object_get_path_string (GST_MESSAGE_SRC (message));
return webkit_user_message_new ("gstwpe.bus_gerror_message",
msg = webkit_user_message_new ("gstwpe.bus_gerror_message",
/* (message_type, src_path, error_domain, error_code, msg, debug_str, details_structure) */ /* (message_type, src_path, error_domain, error_code, msg, debug_str, details_structure) */
g_variant_new ("(sssusss)", g_variant_new ("(sssusss)",
gst_message_type_get_name (GST_MESSAGE_TYPE (message)), gst_message_type_get_name (GST_MESSAGE_TYPE (message)),
@ -69,6 +71,8 @@ create_gerror_bus_msg (GstElement * element, GstMessage * message)
error->code, error->message, debug_str, details_structure) error->code, error->message, debug_str, details_structure)
); );
g_free (src_path); g_free (src_path);
return msg;
} }
/* Those types can't be deserialized on the receiver /* Those types can't be deserialized on the receiver