mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-25 23:46:45 +00:00
Code Issues 1 Projects Releases Wiki Activity

mpegtsdemux: FIXME/Comment about issues/errors

Browse source
This commit is contained in:
Edward Hervey 2012-06-05 09:52:42 +02:00
parent 9e117b83fc
commit d9121c38ea
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/mpegtsdemux/mpegtsbase.c
View file

@ -1185,6 +1185,7 @@ mpegts_base_handle_psi (MpegTSBase * base, MpegTSPacketizerSection * section)
case 0x6E: case 0x6E:
case 0x6F: case 0x6F:
/* EIT, schedule */ /* EIT, schedule */
/* FIXME : Can take up to 50% of total mpeg-ts demuxing cpu usage ! */
structure = mpegts_packetizer_parse_eit (base->packetizer, section); structure = mpegts_packetizer_parse_eit (base->packetizer, section);
if (G_LIKELY (structure)) if (G_LIKELY (structure))
mpegts_base_apply_eit (base, section->pid, structure); mpegts_base_apply_eit (base, section->pid, structure);
@ -1426,6 +1427,10 @@ mpegts_base_chain (GstPad * pad, GstObject * parent, GstBuffer * buf)
goto next; goto next;
} }
/* FIXME : Handle the case where we have multiple sections in one
* packet !
* See bug #677443
*/
/* base PSI data */ /* base PSI data */
if (packet.payload != NULL && mpegts_base_is_psi (base, &packet)) { if (packet.payload != NULL && mpegts_base_is_psi (base, &packet)) {
MpegTSPacketizerSection section; MpegTSPacketizerSection section;

2
gst/mpegtsdemux/mpegtspacketizer.c
View file

@ -1686,6 +1686,7 @@ error:
return NULL; return NULL;
} }
/* FIXME : Can take up to 50% of total mpeg-ts demuxing cpu usage */
GstStructure * GstStructure *
mpegts_packetizer_parse_eit (MpegTSPacketizer2 * packetizer, mpegts_packetizer_parse_eit (MpegTSPacketizer2 * packetizer,
MpegTSPacketizerSection * section) MpegTSPacketizerSection * section)
@ -2813,6 +2814,7 @@ convert_to_utf8 (const gchar * text, gint length, guint start,
text += start; text += start;
/* FIXME : GByteArray has a big overhead */
sb = g_byte_array_sized_new (length * 1.1); sb = g_byte_array_sized_new (length * 1.1);
if (is_multibyte) { if (is_multibyte) {