mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-14 19:35:39 +00:00
Code Issues 1 Projects Releases Wiki Activity

sdp: fix wrong error message for missing clock-rate in caps

Browse source 
When using `gst_sdp_media_set_media_from_caps` on `application/x-rtp` caps
without `clock-rate` it wrongly reports missing payload type even if `payload`
is present in the caps.

This seems to be a copy&paste error from the error message for missing payload
type.

When using payload=10, both `clock-rate` and some other media properties are
defined by the RTP standard so I was wondering whether I could omit `clock-rate`
and was confused about the error message.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5252>
This commit is contained in:
Stephan Seitz 2023-08-26 15:12:05 +02:00 committed by Tim-Philipp Müller
parent 5f433d7ff2
commit d8012a0ead
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gst-plugins-base/gst-libs/gst/sdp/gstsdpmessage.c
View file

@ -3824,7 +3824,7 @@ gst_sdp_media_set_media_from_caps (const GstCaps * caps, GstSDPMedia * media)
/* get clock-rate, media type and params for the rtpmap attribute */ /* get clock-rate, media type and params for the rtpmap attribute */
if (!gst_structure_get_int (s, "clock-rate", &caps_rate)) { if (!gst_structure_get_int (s, "clock-rate", &caps_rate)) {
GST_ERROR ("ignoring stream without payload type"); GST_ERROR ("ignoring stream without clock rate");
goto error; goto error;
} }
caps_enc = gst_structure_get_string (s, "encoding-name"); caps_enc = gst_structure_get_string (s, "encoding-name");