mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-06 22:42:35 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "validate: expect a buffer with discontinuity after a seek"

Browse source 
This reverts commit 87064b6994.

Regressions on the test server, apparently linked to this patchset.
This commit is contained in:
Vincent Penquerc'h 2015-03-09 18:26:06 +00:00
parent 08d8e01f21
commit d78c20322f
3 changed files with 1 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
validate/gst/validate/gst-validate-report.c
View file

@ -186,8 +186,6 @@ gst_validate_report_load_issues (void)
" all buffers coming into the decoders might be checked" " all buffers coming into the decoders might be checked"
" and should have the exact expected metadatas and hash of the" " and should have the exact expected metadatas and hash of the"
" content")); " content"));
REGISTER_VALIDATE_ISSUE (ISSUE, FIRST_BUFFER_NOT_DISCONT,
_("First buffer after a seek does not have the DISCONT flag set"), NULL);
REGISTER_VALIDATE_ISSUE (CRITICAL, WRONG_FLOW_RETURN, REGISTER_VALIDATE_ISSUE (CRITICAL, WRONG_FLOW_RETURN,
_("flow return from pad push doesn't match expected value"), _("flow return from pad push doesn't match expected value"),
_("flow return from a 1:1 sink/src pad element is as simple as " _("flow return from a 1:1 sink/src pad element is as simple as "

1
validate/gst/validate/gst-validate-report.h
View file

@ -63,7 +63,6 @@ typedef enum {
#define WRONG_FLOW_RETURN _QUARK("buffer::wrong-flow-return") #define WRONG_FLOW_RETURN _QUARK("buffer::wrong-flow-return")
#define BUFFER_AFTER_EOS _QUARK("buffer::after-eos") #define BUFFER_AFTER_EOS _QUARK("buffer::after-eos")
#define WRONG_BUFFER _QUARK("buffer::not-expected-one") #define WRONG_BUFFER _QUARK("buffer::not-expected-one")
#define FIRST_BUFFER_NOT_DISCONT _QUARK("buffer::first-buffer-not-discont")
#define CAPS_IS_MISSING_FIELD _QUARK("caps::is-missing-field") #define CAPS_IS_MISSING_FIELD _QUARK("caps::is-missing-field")
#define CAPS_FIELD_HAS_BAD_TYPE _QUARK("caps::field-has-bad-type") #define CAPS_FIELD_HAS_BAD_TYPE _QUARK("caps::field-has-bad-type")

18
validate/gst/validate/gst-validate-scenario.c
View file

@ -436,19 +436,6 @@ gst_validate_action_get_clocktime (GstValidateScenario * scenario,
return TRUE; return TRUE;
} }
static GstPadProbeReturn
_check_discont_buffer_done (GstPad * pad, GstPadProbeInfo * info,
GstValidateAction * action)
{
GstBuffer *buffer = GST_BUFFER (info->data);
if (!GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_DISCONT)) {
GST_VALIDATE_REPORT (action->scenario, FIRST_BUFFER_NOT_DISCONT,
"First buffer after a seek does not have the DISCONT flag set");
}
gst_validate_action_set_done (action);
return GST_PAD_PROBE_REMOVE;
}
static GstPadProbeReturn static GstPadProbeReturn
_check_new_segment_done (GstPad * pad, GstPadProbeInfo * info, _check_new_segment_done (GstPad * pad, GstPadProbeInfo * info,
GstValidateAction * action) GstValidateAction * action)
@ -466,10 +453,7 @@ _check_new_segment_done (GstPad * pad, GstPadProbeInfo * info,
priv->seeked_in_pause = TRUE; priv->seeked_in_pause = TRUE;
gst_event_replace (&priv->last_seek, NULL); gst_event_replace (&priv->last_seek, NULL);
gst_validate_action_set_done (action);
gst_pad_add_probe (pad,
GST_PAD_PROBE_TYPE_BUFFER | GST_PAD_PROBE_TYPE_BUFFER_LIST,
(GstPadProbeCallback) _check_discont_buffer_done, action, NULL);
return GST_PAD_PROBE_REMOVE; return GST_PAD_PROBE_REMOVE;
} }