mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 17:50:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

audiovisualizer: shader: Fix dframe out of bound write

Browse source 
shader_fade_and_move_horiz_out writes a complete stride at the end of its
dframe data

This led to SIGSEGV since the stride reached into sframe->map[0]->memory
which could not be umpapped later on.

This is due to `d` is increased twice. Once at the end of the upper loop
and at the start of the lower loop.
The corresponding dframe stride is therefore skipped.

Rewind `d` and start at the correct position.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1702

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1765>
This commit is contained in:
Sebastian Groß 2022-02-20 14:05:05 +01:00 committed by Tim-Philipp Müller
parent 3e02d2af15
commit d6a5711423
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gst-plugins-base/gst-libs/gst/pbutils/gstaudiovisualizer.c
View file

@ -336,6 +336,10 @@ shader_fade_and_move_horiz_out (GstAudioVisualizer * scope,
} }
d += ds; d += ds;
} }
/* rewind one stride */
d -= ds;
/* move lower half down */ /* move lower half down */
for (j = 0; j < height / 2; j++) { for (j = 0; j < height / 2; j++) {
d += ds; d += ds;