mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-20 21:16:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstobject: Don't check booleans for equality in the unit test

Browse source 
Every value other than 0/FALSE is TRUE, == TRUE will only check for 1.
This commit is contained in:
Sebastian Dröge 2014-11-10 10:01:02 +01:00
parent 5a930aa642
commit d600fc48f8
1 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/check/gst/gstobject.c
View file

@ -355,10 +355,10 @@ GST_START_TEST (test_fake_object_parentage)
fail_if (parent != NULL, "GstFakeObject has parent");
/* try to set a NULL parent, this should give a warning */
ASSERT_CRITICAL (result = gst_object_set_parent (object1, NULL));
fail_if (result == TRUE, "GstFakeObject accepted NULL parent");
fail_if (result, "GstFakeObject accepted NULL parent");
/* try to set itself as parent, we expect a warning here */
ASSERT_CRITICAL (result = gst_object_set_parent (object1, object1));
fail_if (result == TRUE, "GstFakeObject accepted itself as parent");
fail_if (result, "GstFakeObject accepted itself as parent");
/* _has_parent always returns FALSE if there is no parent */
fail_if (gst_object_has_parent (object1, NULL));
@ -379,12 +379,11 @@ GST_START_TEST (test_fake_object_parentage)
"GstFakeObject instance is not floating");
result = gst_object_has_parent (object1, object2);
fail_if (result == TRUE, "GstFakeObject has a parent");
fail_if (result, "GstFakeObject has a parent");
/* try to set other object as parent */
result = gst_object_set_parent (object1, object2);
fail_if (result == FALSE,
"GstFakeObject could not accept other object as parent");
fail_unless (result, "GstFakeObject could not accept other object as parent");
/* should not be floating anymore */
fail_if (g_object_is_floating (object1),
@ -407,7 +406,7 @@ GST_START_TEST (test_fake_object_parentage)
/* try to set other object as parent again */
result = gst_object_set_parent (object1, object2);
fail_if (result == TRUE, "GstFakeObject could set parent twice");
fail_if (result, "GstFakeObject could set parent twice");
/* ref before unparenting */
gst_object_ref (object1);
@ -446,8 +445,7 @@ GST_START_TEST (test_fake_object_parentage_dispose)
/* try to set other object as parent */
result = gst_object_set_parent (object1, object2);
fail_if (result == FALSE,
"GstFakeObject could not accept other object as parent");
fail_unless (result, "GstFakeObject could not accept other object as parent");
/* clear parent of object */
gst_object_unparent (object1);
@ -477,14 +475,11 @@ GST_START_TEST (test_fake_object_has_ancestor)
/* try to set other object as parent */
result = gst_object_set_parent (object1, object3);
fail_if (result == FALSE,
"GstFakeObject could not accept other object as parent");
fail_unless (result, "GstFakeObject could not accept other object as parent");
result = gst_object_set_parent (object2, object3);
fail_if (result == FALSE,
"GstFakeObject could not accept other object as parent");
fail_unless (result, "GstFakeObject could not accept other object as parent");
result = gst_object_set_parent (object3, object4);
fail_if (result == FALSE,
"GstFakeObject could not accept other object as parent");
fail_unless (result, "GstFakeObject could not accept other object as parent");
/* Hierarchy:
* object4