mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-31 12:38:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

sys/v4l2/v4l2src_calls.c: cleanup the error message a bit more

Browse source 
Original commit message from CVS:
* sys/v4l2/v4l2src_calls.c: (gst_v4l2src_fill_format_list),
(gst_v4l2src_queue_frame), (gst_v4l2src_grab_frame),
(gst_v4l2src_get_capture), (gst_v4l2src_set_capture),
(gst_v4l2src_capture_init), (gst_v4l2src_buffer_finalize):
cleanup the error message a bit more
This commit is contained in:
Stefan Kost 2006-11-30 16:46:13 +00:00
parent a7f31a2117
commit d5ce2baebb
2 changed files with 40 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2006-11-30 Stefan Kost <ensonic@users.sf.net>
* sys/v4l2/v4l2src_calls.c: (gst_v4l2src_fill_format_list),
(gst_v4l2src_queue_frame), (gst_v4l2src_grab_frame),
(gst_v4l2src_get_capture), (gst_v4l2src_set_capture),
(gst_v4l2src_capture_init), (gst_v4l2src_buffer_finalize):
cleanup the error message a bit more
2006-11-28 Wim Taymans <wim@fluendo.com> 2006-11-28 Wim Taymans <wim@fluendo.com>
* ext/libcaca/gstcacasink.c: (gst_cacasink_class_init): * ext/libcaca/gstcacasink.c: (gst_cacasink_class_init):

49
sys/v4l2/v4l2src_calls.c
View file

@ -92,7 +92,7 @@ gst_v4l2src_fill_format_list (GstV4l2Src * v4l2src)
failed: failed:
{ {
GST_ELEMENT_ERROR (v4l2src, RESOURCE, SETTINGS, GST_ELEMENT_ERROR (v4l2src, RESOURCE, SETTINGS,
(_("Failed to enumerate possible video formats device '%s' can work with"), v4l2src->v4l2object->videodev), ("Failed to get number %d in pixelformat enumeration for %s. (%d - %s)", n, v4l2src->v4l2object->videodev, errno, strerror (errno))); (_("Failed to enumerate possible video formats device '%s' can work with"), v4l2src->v4l2object->videodev), ("Failed to get number %d in pixelformat enumeration for %s. (%d - %s)", n, v4l2src->v4l2object->videodev, errno, g_strerror (errno)));
g_free (format); g_free (format);
return FALSE; return FALSE;
} }
@ -126,12 +126,12 @@ gst_v4l2src_queue_frame (GstV4l2Src * v4l2src, guint i)
if (ioctl (v4l2src->v4l2object->video_fd, VIDIOC_QBUF, if (ioctl (v4l2src->v4l2object->video_fd, VIDIOC_QBUF,
&v4l2src->pool->buffers[i].buffer) < 0) &v4l2src->pool->buffers[i].buffer) < 0)
goto failed; goto qbuf_failed;
return TRUE; return TRUE;
/* ERRORS */ /* ERRORS */
failed: qbuf_failed:
{ {
GST_ELEMENT_ERROR (v4l2src, RESOURCE, WRITE, GST_ELEMENT_ERROR (v4l2src, RESOURCE, WRITE,
(_("Could not exchange data with device '%s'."), (_("Could not exchange data with device '%s'."),
@ -150,8 +150,9 @@ failed:
gint gint
gst_v4l2src_grab_frame (GstV4l2Src * v4l2src) gst_v4l2src_grab_frame (GstV4l2Src * v4l2src)
{ {
#define NUM_TRIALS 100
struct v4l2_buffer buffer; struct v4l2_buffer buffer;
gint32 trials = 100; gint32 trials = NUM_TRIALS;
memset (&buffer, 0x00, sizeof (buffer)); memset (&buffer, 0x00, sizeof (buffer));
buffer.type = V4L2_BUF_TYPE_VIDEO_CAPTURE; buffer.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
@ -160,7 +161,7 @@ gst_v4l2src_grab_frame (GstV4l2Src * v4l2src)
/* if the sync() got interrupted, we can retry */ /* if the sync() got interrupted, we can retry */
switch (errno) { switch (errno) {
case EAGAIN: case EAGAIN:
GST_DEBUG_OBJECT (v4l2src, GST_WARNING_OBJECT (v4l2src,
"Non-blocking I/O has been selected using O_NONBLOCK and" "Non-blocking I/O has been selected using O_NONBLOCK and"
" no buffer was in the outgoing queue. device %s", " no buffer was in the outgoing queue. device %s",
v4l2src->v4l2object->videodev); v4l2src->v4l2object->videodev);
@ -170,7 +171,7 @@ gst_v4l2src_grab_frame (GstV4l2Src * v4l2src)
case ENOMEM: case ENOMEM:
goto nomem; goto nomem;
case EIO: case EIO:
GST_DEBUG_OBJECT (v4l2src, GST_WARNING_OBJECT (v4l2src,
"VIDIOC_DQBUF failed due to an internal error." "VIDIOC_DQBUF failed due to an internal error."
" Can also indicate temporary problems like signal loss." " Can also indicate temporary problems like signal loss."
" Note the driver might dequeue an (empty) buffer despite" " Note the driver might dequeue an (empty) buffer despite"
@ -178,7 +179,7 @@ gst_v4l2src_grab_frame (GstV4l2Src * v4l2src)
" device %s", v4l2src->v4l2object->videodev); " device %s", v4l2src->v4l2object->videodev);
break; break;
case EINTR: case EINTR:
GST_DEBUG_OBJECT (v4l2src, GST_WARNING_OBJECT (v4l2src,
"could not sync on a buffer on device %s", "could not sync on a buffer on device %s",
v4l2src->v4l2object->videodev); v4l2src->v4l2object->videodev);
break; break;
@ -189,10 +190,12 @@ gst_v4l2src_grab_frame (GstV4l2Src * v4l2src)
break; break;
} }
/* check nr. of attempts to capture */
if (--trials == -1) { if (--trials == -1) {
goto too_many_trials; goto too_many_trials;
} else { } else {
ioctl (v4l2src->v4l2object->video_fd, VIDIOC_QBUF, &buffer); if (ioctl (v4l2src->v4l2object->video_fd, VIDIOC_QBUF, &buffer) < 0)
goto qbuf_failed;
memset (&buffer, 0x00, sizeof (buffer)); memset (&buffer, 0x00, sizeof (buffer));
buffer.type = V4L2_BUF_TYPE_VIDEO_CAPTURE; buffer.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
buffer.memory = v4l2src->breq.memory; buffer.memory = v4l2src->breq.memory;
@ -226,8 +229,17 @@ too_many_trials:
GST_ELEMENT_ERROR (v4l2src, RESOURCE, FAILED, GST_ELEMENT_ERROR (v4l2src, RESOURCE, FAILED,
(_("Failed trying to get video frames from device '%s'."), (_("Failed trying to get video frames from device '%s'."),
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
(_("Failed after 100 tries. device %s."), (_("Failed after %d tries. device %s. system error: %s"),
v4l2src->v4l2object->videodev)); NUM_TRIALS, v4l2src->v4l2object->videodev, g_strerror (errno)));
return -1;
}
qbuf_failed:
{
GST_ELEMENT_ERROR (v4l2src, RESOURCE, WRITE,
(_("Could not exchange data with device '%s'."),
v4l2src->v4l2object->videodev),
("Error queueing buffer on device %s. system error: %s",
v4l2src->v4l2object->videodev, g_strerror (errno)));
return -1; return -1;
} }
} }
@ -260,7 +272,7 @@ fmt_failed:
(_("Failed querying in which video format device '%s' is working with"), (_("Failed querying in which video format device '%s' is working with"),
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("Failed VIDIOC_G_FMT for %s. (%d - %s)", ("Failed VIDIOC_G_FMT for %s. (%d - %s)",
v4l2src->v4l2object->videodev, errno, strerror (errno))); v4l2src->v4l2object->videodev, errno, g_strerror (errno)));
return FALSE; return FALSE;
} }
} }
@ -346,7 +358,7 @@ fmt_failed:
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("Failed to set pixelformat to %s @ %dx%d for device %s. (%d - %s)", ("Failed to set pixelformat to %s @ %dx%d for device %s. (%d - %s)",
fmt->description, *width, *height, fmt->description, *width, *height,
v4l2src->v4l2object->videodev, errno, strerror (errno))); v4l2src->v4l2object->videodev, errno, g_strerror (errno)));
return FALSE; return FALSE;
} }
pixfmt_failed: pixfmt_failed:
@ -356,7 +368,7 @@ pixfmt_failed:
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("Failed to set pixelformat to %s @ %dx%d for device %s. (%d - %s)", ("Failed to set pixelformat to %s @ %dx%d for device %s. (%d - %s)",
fmt->description, *width, *height, fmt->description, *width, *height,
v4l2src->v4l2object->videodev, errno, strerror (errno))); v4l2src->v4l2object->videodev, errno, g_strerror (errno)));
return FALSE; return FALSE;
} }
fail: fail:
@ -484,7 +496,7 @@ broken_driver:
(_("The driver of device '%s' is broken."), (_("The driver of device '%s' is broken."),
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("no supported read capability from %s. (%d - %s)", ("no supported read capability from %s. (%d - %s)",
v4l2src->v4l2object->videodev, errno, strerror (errno))); v4l2src->v4l2object->videodev, errno, g_strerror (errno)));
return FALSE; return FALSE;
} }
no_buffers: no_buffers:
@ -494,7 +506,7 @@ no_buffers:
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("we received %d from device '%s', we want at least %d. (%d - %s))", ("we received %d from device '%s', we want at least %d. (%d - %s))",
v4l2src->breq.count, v4l2src->v4l2object->videodev, v4l2src->breq.count, v4l2src->v4l2object->videodev,
GST_V4L2_MIN_BUFFERS, errno, strerror (errno))); GST_V4L2_MIN_BUFFERS, errno, g_strerror (errno)));
v4l2src->breq.count = buffers; v4l2src->breq.count = buffers;
return FALSE; return FALSE;
} }
@ -504,7 +516,7 @@ querybuf_failed:
(_("Could not get properties of data comming from device '%s'"), (_("Could not get properties of data comming from device '%s'"),
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("Failed querying buffer properties. (%d - %s)", ("Failed querying buffer properties. (%d - %s)",
errno, strerror (errno))); errno, g_strerror (errno)));
gst_v4l2src_capture_deinit (v4l2src); gst_v4l2src_capture_deinit (v4l2src);
return FALSE; return FALSE;
} }
@ -513,7 +525,7 @@ mmap_failed:
GST_ELEMENT_ERROR (v4l2src, RESOURCE, READ, GST_ELEMENT_ERROR (v4l2src, RESOURCE, READ,
(_("Could not map memory in device '%s'."), (_("Could not map memory in device '%s'."),
v4l2src->v4l2object->videodev), v4l2src->v4l2object->videodev),
("mmap failed. (%d - %s)", errno, strerror (errno))); ("mmap failed. (%d - %s)", errno, g_strerror (errno)));
gst_v4l2src_capture_deinit (v4l2src); gst_v4l2src_capture_deinit (v4l2src);
buffer->start = 0; buffer->start = 0;
return FALSE; return FALSE;
@ -928,7 +940,8 @@ gst_v4l2src_buffer_finalize (GstV4l2SrcBuffer * v4l2src_buffer)
if (!g_atomic_int_dec_and_test (&buf->refcount)) { if (!g_atomic_int_dec_and_test (&buf->refcount)) {
/* we're still in use, add to queue again /* we're still in use, add to queue again
note: this might fail because the device is already stopped (race) */ * note: this might fail because the device is already stopped (race)
*/
if (ioctl (buf->pool->video_fd, VIDIOC_QBUF, &buf->buffer) < 0) if (ioctl (buf->pool->video_fd, VIDIOC_QBUF, &buf->buffer) < 0)
GST_INFO ("readding to queue failed, assuming video device is stopped"); GST_INFO ("readding to queue failed, assuming video device is stopped");
} }