fixme: bump leftover 0.11 fixme comments

This commit is contained in:
Stefan Sauer 2014-09-25 21:21:09 +02:00
parent 7bb838be40
commit d5518edf12
13 changed files with 18 additions and 18 deletions

View file

@ -949,7 +949,7 @@ _gst_element_request_pad (GstElement * element, GstPadTemplate * templ,
pad = gst_element_get_static_pad (element, name); pad = gst_element_get_static_pad (element, name);
if (pad) { if (pad) {
gst_object_unref (pad); gst_object_unref (pad);
/* FIXME 0.11: Change this to g_return_val_if_fail() */ /* FIXME 2.0: Change this to g_return_val_if_fail() */
g_critical ("Element %s already has a pad named %s, the behaviour of " g_critical ("Element %s already has a pad named %s, the behaviour of "
" gst_element_get_request_pad() for existing pads is undefined!", " gst_element_get_request_pad() for existing pads is undefined!",
GST_ELEMENT_NAME (element), name); GST_ELEMENT_NAME (element), name);

View file

@ -96,13 +96,13 @@
* </itemizedlist> * </itemizedlist>
*/ */
/* FIXME 0.11: the entire error system needs an overhaul - it's not very /* FIXME 2.0: the entire error system needs an overhaul - it's not very
* useful the way it is. Also, we need to be able to specify additional * useful the way it is. Also, we need to be able to specify additional
* 'details' for errors (e.g. disk/file/resource error -> out-of-space; or * 'details' for errors (e.g. disk/file/resource error -> out-of-space; or
* put the url/filename/device name that caused the error somewhere) * put the url/filename/device name that caused the error somewhere)
* without having to add enums for every little thing. * without having to add enums for every little thing.
* *
* FIXME 0.11: get rid of GST_{CORE,LIBRARY,RESOURCE,STREAM}_ERROR_NUM_ERRORS. * FIXME 2.0: get rid of GST_{CORE,LIBRARY,RESOURCE,STREAM}_ERROR_NUM_ERRORS.
* Maybe also replace _quark() functions with g_quark_from_static_string()? * Maybe also replace _quark() functions with g_quark_from_static_string()?
*/ */
#ifdef HAVE_CONFIG_H #ifdef HAVE_CONFIG_H

View file

@ -1390,7 +1390,7 @@ gst_event_new_reconfigure (void)
* *
* Returns: (transfer full): a new #GstEvent * Returns: (transfer full): a new #GstEvent
*/ */
/* FIXME 0.11: take ownership of msg for consistency? */ /* FIXME 2.0: take ownership of msg for consistency? */
GstEvent * GstEvent *
gst_event_new_sink_message (const gchar * name, GstMessage * msg) gst_event_new_sink_message (const gchar * name, GstMessage * msg)
{ {

View file

@ -1247,7 +1247,7 @@ gst_registry_scan_path_level (GstRegistryScanContext * context,
g_free (filename); g_free (filename);
continue; continue;
} }
/* FIXME 0.11: Don't recurse into directories, this behaviour /* FIXME 2.0: Don't recurse into directories, this behaviour
* is inconsistent with other PATH environment variables * is inconsistent with other PATH environment variables
*/ */
if (level > 0) { if (level > 0) {

View file

@ -1512,7 +1512,7 @@ gst_structure_get_date_time (const GstStructure * structure,
if (!GST_VALUE_HOLDS_DATE_TIME (&field->value)) if (!GST_VALUE_HOLDS_DATE_TIME (&field->value))
return FALSE; return FALSE;
/* FIXME: 0.11 g_value_dup_boxed() -> g_value_get_boxed() */ /* FIXME 2.0: g_value_dup_boxed() -> g_value_get_boxed() */
*value = g_value_dup_boxed (&field->value); *value = g_value_dup_boxed (&field->value);
return TRUE; return TRUE;

View file

@ -1499,7 +1499,7 @@ gst_tag_list_copy_value (GValue * dest, const GstTagList * list,
return TRUE; return TRUE;
} }
/* FIXME 0.11: this whole merge function business is overdesigned, and the /* FIXME 2.0: this whole merge function business is overdesigned, and the
* _get_foo() API is misleading as well - how many application developers will * _get_foo() API is misleading as well - how many application developers will
* expect gst_tag_list_get_string (list, GST_TAG_ARTIST, &val) might return a * expect gst_tag_list_get_string (list, GST_TAG_ARTIST, &val) might return a
* string with multiple comma-separated artists? _get_foo() should just be * string with multiple comma-separated artists? _get_foo() should just be
@ -1798,7 +1798,7 @@ _gst_strdup0 (const gchar * s)
TAG_MERGE_FUNCS (string, gchar *, (*value != NULL)); TAG_MERGE_FUNCS (string, gchar *, (*value != NULL));
/* /*
*FIXME 0.11: Instead of _peek (non-copy) and _get (copy), we could have *FIXME 2.0: Instead of _peek (non-copy) and _get (copy), we could have
* _get (non-copy) and _dup (copy) for strings, seems more * _get (non-copy) and _dup (copy) for strings, seems more
* widely used * widely used
*/ */

View file

@ -2709,7 +2709,7 @@ CREATE_USERIALIZATION (uint, UINT);
CREATE_USERIALIZATION (uint64, UINT64); CREATE_USERIALIZATION (uint64, UINT64);
CREATE_USERIALIZATION (ulong, ULONG); CREATE_USERIALIZATION (ulong, ULONG);
/* FIXME 0.11: remove this again, plugins shouldn't have uchar properties */ /* FIXME 2.0: remove this again, plugins shouldn't have uchar properties */
#ifndef G_MAXUCHAR #ifndef G_MAXUCHAR
#define G_MAXUCHAR 255 #define G_MAXUCHAR 255
#endif #endif

View file

@ -492,7 +492,7 @@ gst_base_sink_class_init (GstBaseSinkClass * klass)
* *
* The amount of bytes to pull when operating in pull mode. * The amount of bytes to pull when operating in pull mode.
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */ /* FIXME 2.0: blocksize property should be int, otherwise min>max.. */
g_object_class_install_property (gobject_class, PROP_BLOCKSIZE, g_object_class_install_property (gobject_class, PROP_BLOCKSIZE,
g_param_spec_uint ("blocksize", "Block size", g_param_spec_uint ("blocksize", "Block size",
"Size in bytes to pull per buffer (0 = default)", 0, G_MAXUINT, "Size in bytes to pull per buffer (0 = default)", 0, G_MAXUINT,
@ -1192,7 +1192,7 @@ gst_base_sink_get_render_delay (GstBaseSink * sink)
* Set the number of bytes that the sink will pull when it is operating in pull * Set the number of bytes that the sink will pull when it is operating in pull
* mode. * mode.
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */ /* FIXME 2.0: blocksize property should be int, otherwise min>max.. */
void void
gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize) gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize)
{ {
@ -1213,7 +1213,7 @@ gst_base_sink_set_blocksize (GstBaseSink * sink, guint blocksize)
* *
* Returns: the number of bytes @sink will pull in pull mode. * Returns: the number of bytes @sink will pull in pull mode.
*/ */
/* FIXME 0.11: blocksize property should be int, otherwise min>max.. */ /* FIXME 2.0: blocksize property should be int, otherwise min>max.. */
guint guint
gst_base_sink_get_blocksize (GstBaseSink * sink) gst_base_sink_get_blocksize (GstBaseSink * sink)
{ {

View file

@ -1103,7 +1103,7 @@ gst_base_src_default_query (GstBaseSrc * src, GstQuery * query)
gst_base_src_seekable (src), 0, duration); gst_base_src_seekable (src), 0, duration);
res = TRUE; res = TRUE;
} else { } else {
/* FIXME 0.11: return TRUE + seekable=FALSE for SEEKING query here */ /* FIXME 2.0: return TRUE + seekable=FALSE for SEEKING query here */
/* Don't reply to the query to make up for demuxers which don't /* Don't reply to the query to make up for demuxers which don't
* handle the SEEKING query yet. Players like Totem will fall back * handle the SEEKING query yet. Players like Totem will fall back
* to the duration when the SEEKING query isn't answered. */ * to the duration when the SEEKING query isn't answered. */

View file

@ -55,7 +55,7 @@ GList *buffers = NULL;
GMutex check_mutex; GMutex check_mutex;
GCond check_cond; GCond check_cond;
/* FIXME 0.11: shouldn't _gst_check_debug be static? Not used anywhere */ /* FIXME 2.0: shouldn't _gst_check_debug be static? Not used anywhere */
gboolean _gst_check_debug = FALSE; gboolean _gst_check_debug = FALSE;
gboolean _gst_check_raised_critical = FALSE; gboolean _gst_check_raised_critical = FALSE;
gboolean _gst_check_raised_warning = FALSE; gboolean _gst_check_raised_warning = FALSE;
@ -603,7 +603,7 @@ buffer_event_function (GstPad * pad, GstObject * noparent, GstEvent * event)
* This can be used to set up a test which pushes some buffers and then an * This can be used to set up a test which pushes some buffers and then an
* invalid buffer, when the final buffer is expected to fail, for example. * invalid buffer, when the final buffer is expected to fail, for example.
*/ */
/* FIXME 0.11: rename this function now that there's GstBufferList? */ /* FIXME 2.0: rename this function now that there's GstBufferList? */
void void
gst_check_element_push_buffer_list (const gchar * element_name, gst_check_element_push_buffer_list (const gchar * element_name,
GList * buffer_in, GstCaps * caps_in, GList * buffer_out, GList * buffer_in, GstCaps * caps_in, GList * buffer_out,

View file

@ -253,7 +253,7 @@ gst_file_src_set_location (GstFileSrc * src, const gchar * location)
GST_INFO ("uri : %s", src->uri); GST_INFO ("uri : %s", src->uri);
} }
g_object_notify (G_OBJECT (src), "location"); g_object_notify (G_OBJECT (src), "location");
/* FIXME 0.11: notify "uri" property once there is one */ /* FIXME 2.0: notify "uri" property once there is one */
return TRUE; return TRUE;

View file

@ -17,7 +17,7 @@
* Boston, MA 02110-1301, USA. * Boston, MA 02110-1301, USA.
*/ */
/* FIXME 0.11: suppress warnings for deprecated API such as GValueArray /* FIXME 2.0: suppress warnings for deprecated API such as GValueArray
* with newer GLib versions (>= 2.31.0) */ * with newer GLib versions (>= 2.31.0) */
#define GLIB_DISABLE_DEPRECATION_WARNINGS #define GLIB_DISABLE_DEPRECATION_WARNINGS

View file

@ -25,7 +25,7 @@
# include "config.h" # include "config.h"
#endif #endif
/* FIXME 0.11: suppress warnings for deprecated API such as GValueArray /* FIXME 2.0: suppress warnings for deprecated API such as GValueArray
* with newer GLib versions (>= 2.31.0) */ * with newer GLib versions (>= 2.31.0) */
#define GLIB_DISABLE_DEPRECATION_WARNINGS #define GLIB_DISABLE_DEPRECATION_WARNINGS