mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin: Post an error message if a stream combiner doesn't return a request pad.

Browse source
This commit is contained in:
Brendan Long 2013-07-01 12:52:43 -06:00 committed by Sebastian Dröge
parent f39d1dc3b4
commit d3acb2b01a
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/playback/gstplaybin2.c
View file

@ -3100,6 +3100,8 @@ pad_added_cb (GstElement * decodebin, GstPad * pad, GstSourceGroup * group)
changed = TRUE; changed = TRUE;
GST_DEBUG_OBJECT (playbin, "linked pad %s:%s to combiner %p", GST_DEBUG_OBJECT (playbin, "linked pad %s:%s to combiner %p",
GST_DEBUG_PAD_NAME (pad), combine->combiner); GST_DEBUG_PAD_NAME (pad), combine->combiner);
} else {
goto request_pad_failed;
} }
} else { } else {
/* no combiner, don't configure anything, we'll link the new pad directly to /* no combiner, don't configure anything, we'll link the new pad directly to
@ -3171,6 +3173,12 @@ link_failed:
GST_SOURCE_GROUP_UNLOCK (group); GST_SOURCE_GROUP_UNLOCK (group);
goto done; goto done;
} }
request_pad_failed:
GST_ELEMENT_ERROR (playbin, CORE, PAD,
("Internal playbin error."),
("Failed to get request pad from combiner %p.", combine->combiner));
GST_SOURCE_GROUP_UNLOCK (group);
goto done;
} }
/* called when a pad is removed from the uridecodebin. We unlink the pad from /* called when a pad is removed from the uridecodebin. We unlink the pad from