mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-22 23:28:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "visual: remove unnecessary variable"

Browse source 
This reverts commit a91d521a36.

Being a base class it is better to check the value instead of ignoring it since
a child class could be created that returns valuable information.
This commit is contained in:
Luis de Bethencourt 2015-01-13 16:09:49 +00:00
parent a91d521a36
commit d3a73827e0
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ext/libvisual/gstaudiovisualizer.c
View file

@ -726,6 +726,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps)
{ {
GstVideoInfo info; GstVideoInfo info;
GstAudioVisualizerClass *klass; GstAudioVisualizerClass *klass;
gboolean res;
if (!gst_video_info_from_caps (&info, caps)) if (!gst_video_info_from_caps (&info, caps))
goto wrong_caps; goto wrong_caps;
@ -750,7 +751,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps)
GST_MAP_READWRITE); GST_MAP_READWRITE);
if (klass->setup) if (klass->setup)
klass->setup (scope); res = klass->setup (scope);
GST_DEBUG_OBJECT (scope, "video: dimension %dx%d, framerate %d/%d", GST_DEBUG_OBJECT (scope, "video: dimension %dx%d, framerate %d/%d",
GST_VIDEO_INFO_WIDTH (&info), GST_VIDEO_INFO_HEIGHT (&info), GST_VIDEO_INFO_WIDTH (&info), GST_VIDEO_INFO_HEIGHT (&info),
@ -761,7 +762,9 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps)
gst_pad_set_caps (scope->srcpad, caps); gst_pad_set_caps (scope->srcpad, caps);
/* find a pool for the negotiated caps now */ /* find a pool for the negotiated caps now */
return gst_audio_visualizer_do_bufferpool (scope, caps); res = gst_audio_visualizer_do_bufferpool (scope, caps);
return res;
/* ERRORS */ /* ERRORS */
wrong_caps: wrong_caps: