mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 14:06:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

baseparse: Set the private duration before posting a duration-changed message

Browse source 
Otherwise an application cannot rely on a subsequent call to e.g. gst_pad_query_duration() succeeding.
This commit is contained in:
Zebediah Figura 2020-02-10 16:35:06 -06:00 committed by Tim-Philipp Müller
parent 733246f1b4
commit d28e0b4147
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libs/gst/base/gstbaseparse.c
View file

@ -3840,6 +3840,8 @@ void
gst_base_parse_set_duration (GstBaseParse * parse, gst_base_parse_set_duration (GstBaseParse * parse,
GstFormat fmt, gint64 duration, gint interval) GstFormat fmt, gint64 duration, gint interval)
{ {
gint64 old_duration;
g_return_if_fail (parse != NULL); g_return_if_fail (parse != NULL);
if (parse->priv->upstream_has_duration) { if (parse->priv->upstream_has_duration) {
@ -3847,14 +3849,8 @@ gst_base_parse_set_duration (GstBaseParse * parse,
goto exit; goto exit;
} }
if (duration != parse->priv->duration) { old_duration = parse->priv->duration;
GstMessage *m;
m = gst_message_new_duration_changed (GST_OBJECT (parse));
gst_element_post_message (GST_ELEMENT (parse), m);
/* TODO: what about duration tag? */
}
parse->priv->duration = duration; parse->priv->duration = duration;
parse->priv->duration_fmt = fmt; parse->priv->duration_fmt = fmt;
GST_DEBUG_OBJECT (parse, "set duration: %" G_GINT64_FORMAT, duration); GST_DEBUG_OBJECT (parse, "set duration: %" G_GINT64_FORMAT, duration);
@ -3866,6 +3862,14 @@ gst_base_parse_set_duration (GstBaseParse * parse,
} }
GST_DEBUG_OBJECT (parse, "set update interval: %d", interval); GST_DEBUG_OBJECT (parse, "set update interval: %d", interval);
parse->priv->update_interval = interval; parse->priv->update_interval = interval;
if (duration != old_duration) {
GstMessage *m;
m = gst_message_new_duration_changed (GST_OBJECT (parse));
gst_element_post_message (GST_ELEMENT (parse), m);
/* TODO: what about duration tag? */
}
exit: exit:
return; return;
} }