mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-18 21:35:44 +00:00
Code Issues 1 Projects Releases Wiki Activity

collectpads: Don't unref NULL GstCollectData

Browse source 
If a pad is removed while a collectpads element (say adder) is in a chain
function waiting to be collected, there is a possibility that an unref happens
on a NULL pointer.

https://bugzilla.gnome.org/show_bug.cgi?id=707536
This commit is contained in:
Zaheer Abbas Merali 2013-09-05 14:14:42 +02:00 committed by Sebastian Dröge
parent 26c481e592
commit d1d99af229
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/gst/base/gstcollectpads.c
View file

@ -2068,7 +2068,9 @@ gst_collect_pads_chain (GstPad * pad, GstObject * parent, GstBuffer * buffer)
unlock_done: unlock_done:
GST_COLLECT_PADS_STREAM_UNLOCK (pads); GST_COLLECT_PADS_STREAM_UNLOCK (pads);
unref_data (data); /* data is definitely NULL if pad_removed goto was run. */
if (data)
unref_data (data);
if (buffer) if (buffer)
gst_buffer_unref (buffer); gst_buffer_unref (buffer);
return ret; return ret;