mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

closedcaption: Don't leak caps event

Browse source 
All events that we handle should be unreffed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3902>
This commit is contained in:
Edward Hervey 2023-02-07 08:49:24 +01:00 committed by Edward Hervey
parent 621604aa3e
commit d10f9a00e2
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gst-plugins-bad/ext/closedcaption/gstceaccoverlay.c
View file

@ -988,7 +988,6 @@ gst_cea_cc_overlay_cc_event (GstPad * pad, GstObject * parent, GstEvent * event)
("received non-TIME newsegment event on text input")); ("received non-TIME newsegment event on text input"));
} }
gst_event_unref (event);
ret = TRUE; ret = TRUE;
/* wake up the video chain, it might be waiting for a text buffer or /* wake up the video chain, it might be waiting for a text buffer or
@ -1015,7 +1014,6 @@ gst_cea_cc_overlay_cc_event (GstPad * pad, GstObject * parent, GstEvent * event)
GST_CEA_CC_OVERLAY_BROADCAST (overlay); GST_CEA_CC_OVERLAY_BROADCAST (overlay);
GST_CEA_CC_OVERLAY_UNLOCK (overlay); GST_CEA_CC_OVERLAY_UNLOCK (overlay);
gst_event_unref (event);
ret = TRUE; ret = TRUE;
break; break;
} }
@ -1027,7 +1025,6 @@ gst_cea_cc_overlay_cc_event (GstPad * pad, GstObject * parent, GstEvent * event)
gst_cea_cc_overlay_pop_text (overlay); gst_cea_cc_overlay_pop_text (overlay);
gst_segment_init (&overlay->cc_segment, GST_FORMAT_TIME); gst_segment_init (&overlay->cc_segment, GST_FORMAT_TIME);
GST_CEA_CC_OVERLAY_UNLOCK (overlay); GST_CEA_CC_OVERLAY_UNLOCK (overlay);
gst_event_unref (event);
ret = TRUE; ret = TRUE;
break; break;
case GST_EVENT_FLUSH_START: case GST_EVENT_FLUSH_START:
@ -1036,7 +1033,6 @@ gst_cea_cc_overlay_cc_event (GstPad * pad, GstObject * parent, GstEvent * event)
overlay->cc_flushing = TRUE; overlay->cc_flushing = TRUE;
GST_CEA_CC_OVERLAY_BROADCAST (overlay); GST_CEA_CC_OVERLAY_BROADCAST (overlay);
GST_CEA_CC_OVERLAY_UNLOCK (overlay); GST_CEA_CC_OVERLAY_UNLOCK (overlay);
gst_event_unref (event);
ret = TRUE; ret = TRUE;
break; break;
case GST_EVENT_EOS: case GST_EVENT_EOS:
@ -1047,14 +1043,18 @@ gst_cea_cc_overlay_cc_event (GstPad * pad, GstObject * parent, GstEvent * event)
* a text segment update */ * a text segment update */
GST_CEA_CC_OVERLAY_BROADCAST (overlay); GST_CEA_CC_OVERLAY_BROADCAST (overlay);
GST_CEA_CC_OVERLAY_UNLOCK (overlay); GST_CEA_CC_OVERLAY_UNLOCK (overlay);
gst_event_unref (event);
ret = TRUE; ret = TRUE;
break; break;
default: default:
ret = gst_pad_event_default (pad, parent, event);
break; break;
} }
if (ret) {
gst_event_unref (event);
} else {
ret = gst_pad_event_default (pad, parent, event);
}
return ret; return ret;
} }