gst-libs/gst/rtp/gstbasertppayload.c: Don't break ABI, restore previous ranges. Keep the default random selection of ...

Original commit message from CVS:
* gst-libs/gst/rtp/gstbasertppayload.c:
(gst_basertppayload_class_init), (gst_basertppayload_init),
(gst_basertppayload_set_property),
(gst_basertppayload_get_property):
Don't break ABI, restore previous ranges. Keep the default random
selection of timestamp and seqnum offset but as soon as the app sets a
specific value, use that one.
This commit is contained in:
Wim Taymans 2007-07-16 10:10:28 +00:00
parent 312c0bd5ba
commit d0e9a76a95
2 changed files with 23 additions and 13 deletions

View file

@ -1,3 +1,13 @@
2007-07-16 Wim Taymans <wim.taymans@gmail.com>
* gst-libs/gst/rtp/gstbasertppayload.c:
(gst_basertppayload_class_init), (gst_basertppayload_init),
(gst_basertppayload_set_property),
(gst_basertppayload_get_property):
Don't break ABI, restore previous ranges. Keep the default random
selection of timestamp and seqnum offset but as soon as the app sets a
specific value, use that one.
2007-07-14 Wim Taymans <wim.taymans@gmail.com> 2007-07-14 Wim Taymans <wim.taymans@gmail.com>
Patch by: Bastien Nocera <hadess at hadess dot net> Patch by: Bastien Nocera <hadess at hadess dot net>

View file

@ -162,13 +162,13 @@ gst_basertppayload_class_init (GstBaseRTPPayloadClass * klass)
"The payload type of the packets", "The payload type of the packets",
0, 0x80, DEFAULT_PT, G_PARAM_READWRITE)); 0, 0x80, DEFAULT_PT, G_PARAM_READWRITE));
g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_SSRC, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_SSRC,
g_param_spec_int64 ("ssrc", "SSRC", g_param_spec_uint ("ssrc", "SSRC",
"The SSRC of the packets (-1 == random)", "The SSRC of the packets (default == random)",
-1, G_MAXUINT32, DEFAULT_SSRC, G_PARAM_READWRITE)); 0, G_MAXUINT32, DEFAULT_SSRC, G_PARAM_READWRITE));
g_object_class_install_property (G_OBJECT_CLASS (klass), g_object_class_install_property (G_OBJECT_CLASS (klass),
PROP_TIMESTAMP_OFFSET, g_param_spec_int64 ("timestamp-offset", PROP_TIMESTAMP_OFFSET, g_param_spec_uint ("timestamp-offset",
"Timestamp Offset", "Timestamp Offset",
"Offset to add to all outgoing timestamps (-1 = random)", -1, "Offset to add to all outgoing timestamps (default = random)", 0,
G_MAXUINT32, DEFAULT_TIMESTAMP_OFFSET, G_PARAM_READWRITE)); G_MAXUINT32, DEFAULT_TIMESTAMP_OFFSET, G_PARAM_READWRITE));
g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_SEQNUM_OFFSET, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_SEQNUM_OFFSET,
g_param_spec_int ("seqnum-offset", "Sequence number Offset", g_param_spec_int ("seqnum-offset", "Sequence number Offset",
@ -518,14 +518,14 @@ gst_basertppayload_set_property (GObject * object, guint prop_id,
basertppayload->pt = g_value_get_uint (value); basertppayload->pt = g_value_get_uint (value);
break; break;
case PROP_SSRC: case PROP_SSRC:
val = g_value_get_int64 (value); val = g_value_get_uint (value);
basertppayload->ssrc = val; basertppayload->ssrc = val;
priv->ssrc_random = (val == -1); priv->ssrc_random = FALSE;
break; break;
case PROP_TIMESTAMP_OFFSET: case PROP_TIMESTAMP_OFFSET:
val = g_value_get_int64 (value); val = g_value_get_uint (value);
basertppayload->ts_offset = val; basertppayload->ts_offset = val;
priv->ts_offset_random = (val == -1); priv->ts_offset_random = FALSE;
break; break;
case PROP_SEQNUM_OFFSET: case PROP_SEQNUM_OFFSET:
val = g_value_get_int (value); val = g_value_get_int (value);
@ -565,15 +565,15 @@ gst_basertppayload_get_property (GObject * object, guint prop_id,
break; break;
case PROP_SSRC: case PROP_SSRC:
if (priv->ssrc_random) if (priv->ssrc_random)
g_value_set_int64 (value, -1); g_value_set_uint (value, -1);
else else
g_value_set_int64 (value, basertppayload->ssrc); g_value_set_uint (value, basertppayload->ssrc);
break; break;
case PROP_TIMESTAMP_OFFSET: case PROP_TIMESTAMP_OFFSET:
if (priv->ts_offset_random) if (priv->ts_offset_random)
g_value_set_int64 (value, -1); g_value_set_uint (value, -1);
else else
g_value_set_int64 (value, (guint32) basertppayload->ts_offset); g_value_set_uint (value, (guint32) basertppayload->ts_offset);
break; break;
case PROP_SEQNUM_OFFSET: case PROP_SEQNUM_OFFSET:
if (priv->seqnum_offset_random) if (priv->seqnum_offset_random)