mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

codecparsers: av1: fix underflow in last_frame_idx

Browse source 
The spec mandates this field be parsed using unsigned arithmetic. Nevertheless,
av1parser will use -1 apparently as an uninitialized value in
gst_av1_parse_frame_header. This immediately underflows last_frame_idx
though, since its type was defined as guint8. Fix this by converting to gint8.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2401>
This commit is contained in:
Daniel Almeida 2021-07-12 09:01:06 -03:00 committed by GStreamer Marge Bot
parent 211f968981
commit d0e614b354
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst-libs/gst/codecparsers/gstav1parser.h
View file

@ -1560,7 +1560,7 @@ struct _GstAV1FrameHeaderOBU {
guint32 ref_order_hint[GST_AV1_NUM_REF_FRAMES]; guint32 ref_order_hint[GST_AV1_NUM_REF_FRAMES];
gboolean allow_intrabc; gboolean allow_intrabc;
gboolean frame_refs_short_signaling; gboolean frame_refs_short_signaling;
guint8 last_frame_idx; gint8 last_frame_idx;
gint8 gold_frame_idx; gint8 gold_frame_idx;
gint8 ref_frame_idx[GST_AV1_REFS_PER_FRAME]; gint8 ref_frame_idx[GST_AV1_REFS_PER_FRAME];
gboolean allow_high_precision_mv; gboolean allow_high_precision_mv;