mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-24 02:31:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

plug a memleak

Browse source 
Original commit message from CVS:
plug a memleak
This commit is contained in:
Colin Walters 2004-04-30 20:57:48 +00:00
parent 6e19650c97
commit d0d062e9ae
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ChangeLog
View file

@ -1,3 +1,7 @@
2004-04-30 Colin Walters <walters@verbum.org>
* ext/alsa/gstalsasink.c (gst_alsa_sink_mmap): Plug a memleak.
2004-04-30 Thomas Vander Stichele <thomas at apestaart dot org> 2004-04-30 Thomas Vander Stichele <thomas at apestaart dot org>
* gst/ffmpegcolorspace/gstffmpegcolorspace.c: * gst/ffmpegcolorspace/gstffmpegcolorspace.c:

12
ext/alsa/gstalsasink.c
View file

@ -254,7 +254,9 @@ gst_alsa_sink_mmap (GstAlsa * this, snd_pcm_sframes_t * avail)
const snd_pcm_channel_area_t *dst; const snd_pcm_channel_area_t *dst;
snd_pcm_channel_area_t *src; snd_pcm_channel_area_t *src;
GstAlsaSink *sink = GST_ALSA_SINK (this); GstAlsaSink *sink = GST_ALSA_SINK (this);
int i, err, width = snd_pcm_format_physical_width (this->format->format); int i;
int err = -1;
int width = snd_pcm_format_physical_width (this->format->format);
/* areas points to the memory areas that belong to gstreamer. */ /* areas points to the memory areas that belong to gstreamer. */
src = g_malloc0 (this->format->channels * sizeof (snd_pcm_channel_area_t)); src = g_malloc0 (this->format->channels * sizeof (snd_pcm_channel_area_t));
@ -277,7 +279,7 @@ gst_alsa_sink_mmap (GstAlsa * this, snd_pcm_sframes_t * avail)
if ((err = snd_pcm_mmap_begin (this->handle, &dst, &offset, avail)) < 0) { if ((err = snd_pcm_mmap_begin (this->handle, &dst, &offset, avail)) < 0) {
GST_ERROR_OBJECT (this, "mmap failed: %s", snd_strerror (err)); GST_ERROR_OBJECT (this, "mmap failed: %s", snd_strerror (err));
return -1; goto out;
} }
if ((err = if ((err =
@ -285,13 +287,15 @@ gst_alsa_sink_mmap (GstAlsa * this, snd_pcm_sframes_t * avail)
*avail, this->format->format)) < 0) { *avail, this->format->format)) < 0) {
snd_pcm_mmap_commit (this->handle, offset, 0); snd_pcm_mmap_commit (this->handle, offset, 0);
GST_ERROR_OBJECT (this, "data copy failed: %s", snd_strerror (err)); GST_ERROR_OBJECT (this, "data copy failed: %s", snd_strerror (err));
return -1; goto out;
} }
if ((err = snd_pcm_mmap_commit (this->handle, offset, *avail)) < 0) { if ((err = snd_pcm_mmap_commit (this->handle, offset, *avail)) < 0) {
GST_ERROR_OBJECT (this, "mmap commit failed: %s", snd_strerror (err)); GST_ERROR_OBJECT (this, "mmap commit failed: %s", snd_strerror (err));
return -1; goto out;
} }
out:
g_free (src);
return err; return err;
} }
static int static int