mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-29 23:32:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

title: Deprecate method that return newly allocated const gchar*

Browse source 
This is just plain broken 190643508f
but we can't do anything about it.
This commit is contained in:
Thibault Saunier 2019-04-08 16:23:18 -04:00
parent 5c54ba55b7
commit cfd5fda38d
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ges/ges-title-source.c
View file

@ -450,7 +450,10 @@ ges_title_source_set_ypos (GESTitleSource * self, gdouble position)
* *
* Get the text currently set on the @source. * Get the text currently set on the @source.
* *
* Returns: (transfer none): The text currently set on the @source. * Returns: (transfer full): The text currently set on the @source.
*
* Deprecated: 1.16: Use ges_timeline_element_get_child_property instead
* (this actually returns a newly allocated string)
*/ */
const gchar * const gchar *
ges_title_source_get_text (GESTitleSource * source) ges_title_source_get_text (GESTitleSource * source)
@ -469,8 +472,11 @@ ges_title_source_get_text (GESTitleSource * source)
* *
* Get the pango font description used by @source. * Get the pango font description used by @source.
* *
* Returns: (transfer none): The pango font description used by this * Returns: (transfer full): The pango font description used by this
* @source. * @source.
*
* Deprecated: 1.16: Use ges_timeline_element_get_child_property instead
* (this actually returns a newly allocated string)
*/ */
const gchar * const gchar *
ges_title_source_get_font_desc (GESTitleSource * source) ges_title_source_get_font_desc (GESTitleSource * source)

7
tests/check/ges/titles.c
View file

@ -148,19 +148,12 @@ GST_START_TEST (test_title_source_in_layer)
track_element = track_element =
ges_clip_find_track_element (GES_CLIP (source), v, GES_TYPE_TITLE_SOURCE); ges_clip_find_track_element (GES_CLIP (source), v, GES_TYPE_TITLE_SOURCE);
/* Check the text is still the same */
assert_equals_string (ges_title_source_get_text (GES_TITLE_SOURCE
(track_element)), "some text");
/* test the font-desc property */ /* test the font-desc property */
g_object_set (source, "font-desc", (gchar *) "sans 72", NULL); g_object_set (source, "font-desc", (gchar *) "sans 72", NULL);
g_object_get (source, "font-desc", &text, NULL); g_object_get (source, "font-desc", &text, NULL);
assert_equals_string ("sans 72", text); assert_equals_string ("sans 72", text);
g_free (text); g_free (text);
assert_equals_string ("sans 72",
ges_title_source_get_font_desc (GES_TITLE_SOURCE (track_element)));
/* test halign and valign */ /* test halign and valign */
g_object_set (source, "halignment", (gint) g_object_set (source, "halignment", (gint)
GES_TEXT_HALIGN_LEFT, "valignment", (gint) GES_TEXT_VALIGN_TOP, NULL); GES_TEXT_HALIGN_LEFT, "valignment", (gint) GES_TEXT_VALIGN_TOP, NULL);